Moq Verify 表示方法从未被调用，但实际上它已经被调用了。

huangapple
go评论91阅读模式
英文:

Moq Verify says method was never called, but it was

问题

以下是代码部分的中文翻译：

  1. public class KafkaConsumerService : BackgroundService
  2. {
  3.     private readonly IConsumer<string, Transaction> _kafkaConsumer;
  4.     private readonly IRepository _repository;
  5.     private readonly ICalculator _calculator;
  7.     public KafkaConsumerService(
  8.         IConsumer<string, Transaction> kafkaConsumer,
  9.         IRepository repository,
  10.         ICalculator calculator
  11.     )
  12.     {
  13.         _kafkaConsumer = kafkaConsumer;
  14.         _repository = repository;
  15.         _calculator = calculator;
  16.     }
  18.     protected override async Task ExecuteAsync(CancellationToken stoppingToken)
  19.     {
  20.         var consumeResult = await Task.Run(() => _kafkaConsumer.Consume(stoppingToken), stoppingToken);
  21.         var transaction = consumeResult.Message.Value;
  23.         var account = await _repository.GetAccount(transaction.Account);
  24.         await _repository.UpdateAccount(_calculator.CalculateAccount(account, Normalize(transaction)));
  25.     }
  27.     private Transaction Normalize(Transaction transaction)
  28.     {
  29.         if (!transaction.IsCancellation)
  30.         {
  31.             return transaction;
  32.         }
  34.         return new Transaction(transaction)
  35.         {
  36.             Amount = transaction.Amount * -1,
  37.             IsCancellation = false
  38.         };
  39.     }
  40. }
  1. public class KafkaConsumerServiceTest
  2. {
  3.     private readonly Mock<IConsumer<string, Transaction>> _kafka = new();
  4.     private readonly Mock<IRepository> _repository = new();
  5.     private readonly Mock<ICalculator> _calculator = new();
  7.     private readonly Fixture _fixture = new();
  8.     private readonly KafkaConsumerService _kafkaConsumerService;
  10.     public KafkaConsumerServiceTest()
  11.     {
  12.         _kafkaConsumerService = new KafkaConsumerService(_kafka.Object, _repository.Object, _calculator.Object);
  13.     }
  15.     [Fact]
  16.     public async Task KafkaConsumerService_ProcessesCancelationTransaction()
  17.     {
  18.         _fixture.Customize<Transaction>(composer => composer
  19.             .With(transaction => transaction.IsCancellation, true)
  20.         );
  22.         var transaction = _fixture.Create<Transaction>();
  23.         _kafka
  24.             .Setup(consumer => consumer.Consume(It.IsAny<CancellationToken>()))
  25.             .Returns(new ConsumeResult<string, Transaction>
  26.             {
  27.                 Message = new Message<string, Transaction>
  28.                 {
  29.                     Value = transaction,
  30.                 },
  31.             });
  33.         var result = _fixture.Create<Account>() with
  34.         {
  35.             AccountName = transaction.Account
  36.         };
  38.         _repository
  39.             .Setup(repository => repository.GetAccount(transaction.Account))
  40.             .ReturnsAsync(result);
  42.         _calculator
  43.             .Setup(calculator => calculator.CalculateAccount(It.IsAny<Account?>(), It.IsAny<Transaction>()))
  44.             .Returns(result);
  46.         await _kafkaConsumerService.StartAsync(CancellationToken.None);
  48.         _repository.Verify(repository =>
  49.             repository.GetAccount(transaction.Account)
  50.         );
  51.         _calculator.Verify(calculator =>
  52.             calculator.CalculateAccount(result, transaction)
  53.         );
  54.         _repository.Verify(repository => repository.UpdateAccount(result));
  55.     }
  56. }

这些是您提供的代码的中文翻译部分。如果您需要更多帮助或其他问题的翻译，请随时告诉我。

英文:

I have the following code which reads a Transaction from Kafka, and updates the account balance to show that transaction

  1. public class KafkaConsumerService : BackgroundService
  2. {
  3.     private readonly IConsumer&lt;string, Transaction&gt; _kafkaConsumer;
  4.     private readonly IRepository _repository;
  5.     private readonly ICalculator _calculator;
  7.     public KafkaConsumerService(
  8.         IConsumer&lt;string, Transaction&gt; kafkaConsumer,
  9.         IRepository repository,
  10.         ICalculator calculator
  11.     )
  12.     {
  13.         _kafkaConsumer = kafkaConsumer;
  14.         _repository = repository;
  15.         _calculator = calculator;
  16.     }
  18.     protected override async Task ExecuteAsync(CancellationToken stoppingToken)
  19.     {
  20.         var consumeResult = await Task.Run(() =&gt; _kafkaConsumer.Consume(stoppingToken), stoppingToken);
  21.         var transaction = consumeResult.Message.Value;
  23.         var account = await _repository.GetAccount(transaction.Account);
  24.         await _repository.UpdateAccount(_calculator.CalculateAccount(account, Normalize(transaction)));
  25.     }
  27.     private Transaction Normalize(Transaction transaction)
  28.     {
  29.         if (!transaction.IsCancellation)
  30.         {
  31.             return transaction;
  32.         }
  34.         return new Transaction(transaction)
  35.         {
  36.             Amount = transaction.Amount * -1,
  37.             IsCancellation = false
  38.         };
  39.     }
  40. }

I have then written the following unit test for this, using XUnit and Moq

  1. public class KafkaConsumerServiceTest
  2. {
  3.     private readonly Mock&lt;IConsumer&lt;string, Transaction&gt;&gt; _kafka = new();
  4.     private readonly Mock&lt;IRepository&gt; _repository = new();
  5.     private readonly Mock&lt;ICalculator&gt; _calculator = new();
  7.     private readonly Fixture _fixture = new();
  8.     private readonly KafkaConsumerService _kafkaConsumerService;
  10.     public KafkaConsumerServiceTest()
  11.     {
  12.         _kafkaConsumerService = new KafkaConsumerService(_kafka.Object, _repository.Object, _calculator.Object);
  13.     }
  15.     [Fact]
  16.     public async Task KafkaConsumerService_ProcessesCancelationTransaction()
  17.     {
  18.         _fixture.Customize&lt;Transaction&gt;(composer =&gt; composer
  19.             .With(transaction =&gt; transaction.IsCancellation, true)
  20.         );
  22.         var transaction = _fixture.Create&lt;Transaction&gt;();
  23.         _kafka
  24.             .Setup(consumer =&gt; consumer.Consume(It.IsAny&lt;CancellationToken&gt;()))
  25.             .Returns(new ConsumeResult&lt;string, Transaction&gt;
  26.             {
  27.                 Message = new Message&lt;string, Transaction&gt;
  28.                 {
  29.                     Value = transaction,
  30.                 },
  31.             });
  33.         var result = _fixture.Create&lt;Account&gt;() with
  34.         {
  35.             AccountName = transaction.Account
  36.         };
  38.         _repository
  39.             .Setup(repository =&gt; repository.GetAccount(transaction.Account))
  40.             .ReturnsAsync(result);
  42.         _calculator
  43.             .Setup(calculator =&gt; calculator.CalculateAccount(It.IsAny&lt;Account?&gt;(), It.IsAny&lt;Transaction&gt;()))
  44.             .Returns(result);
  46.         await _kafkaConsumerService.StartAsync(CancellationToken.None);
  48.         _repository.Verify(repository =&gt;
  49.             repository.GetAccount(transaction.Account)
  50.         );
  51.         _calculator.Verify(calculator =&gt;
  52.             calculator.CalculateAccount(result, transaction)
  53.         );
  54.         _repository.Verify(repository =&gt; repository.UpdateAccount(result));
  55.     }
  56. }

However I then get the following error

  1. Moq.MockException
  3. Expected invocation on the mock at least once, but was never performed: repository =&gt; repository.GetAccount(&quot;Account73ccea18-e39c-493f-9533-7af7f983b8ab&quot;)
  5. Performed invocations:
  7.    Mock&lt;IRepository:1&gt; (repository):
  9.       IRepository.GetAccount(&quot;Account73ccea18-e39c-493f-9533-7af7f983b8ab&quot;)
  10.       IRepository.UpdateAccount(Account { AccountName = Account73ccea18-e39c-493f-9533-7af7f983b8ab, Amount = 119 })

As you can see it says the method GetAccount(&quot;Account73ccea18-e39c-493f-9533-7af7f983b8ab&quot;) was never called, however right below it under Performed invocations, it says it was called.

If anyone has any ideas as to what is going wrong here I would appreciate it.

EDIT
Adding an await Task.Delay(100) on the unit tests seem to fix the problem, however this isnt an ideal solution, and I still dont understand why the issue occurs in the first place.

EDIT #2
It seems that removing the extension of BackgroundService (https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.hosting.backgroundservice?view=dotnet-plat-ext-7.0) seems to fix the test aswell. Could this somehow be causing a race condition in my code?

答案1

得分: 0

I think the culprit could be this:

  1. return new Transaction(transaction)
  2. {
  3.     Amount = transaction.Amount * -1,
  4.     IsCancellation = false
  5. };

When you verify against an instance, it is doing a reference check so it cannot be a different newly made object.

Try

  1. _repository.Verify(repository =>
  2.     repository.GetAccount(It.IsAny<string>())
  3. );
  4. _repository.Verify(repository => repository.UpdateAccount(It.IsAny<Transaction>()));

You may also use It.Is<Transaction>(t => t.AccountName == "account") to validate specific values in the assertion.

英文:

I think the culprit could be this:

  1. return new Transaction(transaction)
  2. {
  3.     Amount = transaction.Amount * -1,
  4.     IsCancellation = false
  5. };

When you verify against an instance, it is doing a reference check so it cannot be a different newly made object.

Try

  1. _repository.Verify(repository =&gt;
  2.     repository.GetAccount(It.IsAny&lt;string&gt;())
  3. );
  4. _repository.Verify(repository =&gt; repository.UpdateAccount(It.IsAny&lt;Transaction&gt;()));

You may also use It.Is&lt;Transaction&gt;(t =&gt; t.AccountName == &quot;account&quot;) to validate specific values in the assertion.

答案2

得分: 0

以下是您要翻译的代码部分：

  1. 查看更多细节。看起来 `BackgroundService.StartAsync` 将调用 `ExecuteAsync`，然后返回 `Task.CompletedTask`。
  3. public virtual Task StartAsync(CancellationToken cancellationToken)
  4. {
  5.      // 存储我们正在执行的任务
  6.     _executingTask = ExecuteAsync(_stoppingCts.Token);
  8.     // 如果任务已经完成，则返回它，
  9.     // 这将传递取消和失败给调用者
  10.     if (_executingTask.IsCompleted)
  11.     {
  12.         return _executingTask;
  13.     }
  15.     // 否则，它正在运行
  16.     return Task.CompletedTask;
  17. }

这导致我的代码尚未完成执行，因此我的 moq 断言失败。我认为这两者之间的时间非常接近，因此在生成错误时，方法已被调用，这就是令人困惑的错误消息原因。

我通过简单地等待执行的任务完成来解决了这个问题：

  1. await _kafkaConsumerService.StartAsync(CancellationToken.None);
  2. await _kafkaConsumerService.ExecuteTask;

（请注意，上述代码是根据您提供的信息翻译的，其中包含了代码部分。）

英文:

Looking into this further. It appears that BackgroundService.StartAsync will call ExecuteAsync, and then return Task.CompletedTask

  1. public virtual Task StartAsync(CancellationToken cancellationToken)
  2. {
  3.      // Store the task we&#39;re executing
  4.     _executingTask = ExecuteAsync(_stoppingCts.Token);
  6.     // If the task is completed then return it,
  7.     // this will bubble cancellation and failure to the caller
  8.     if (_executingTask.IsCompleted)
  9.     {
  10.         return _executingTask;
  11.     }
  13.     // Otherwise it&#39;s running
  14.     return Task.CompletedTask;
  15. }

This then meant that my code has not finished executing yet, hence why my moq assertions failed. I then assume that the timing between these two was very close, so that by the time the error was generated, the methods had been called hence the confusing error message.

I fixed this issue by simply waiting for the executed task to be completed

  1. await _kafkaConsumerService.StartAsync(CancellationToken.None);
  2. await _kafkaConsumerService.ExecuteTask;

huangapple
  • 本文由 发表于 2023年2月19日 00:07:17
  • 转载请务必保留本文链接：https://go.coder-hub.com/75494603.html
  • c#
  • moq
  • xunit
匿名

发表评论

匿名网友

:?: :razz: :sad: :evil: :!: :smile: :oops: :grin: :eek: :shock: :???: :cool: :lol: :mad: :twisted: :roll: :wink: :idea: :arrow: :neutral: :cry: :mrgreen:

确定