如何测试实现了Gorilla上下文的函数？

huangapple
go评论112阅读模式
英文:

How to test functions that implement gorilla context

问题

我写了一个将数据保存到Redis数据库服务器的函数。挑战在于我想测试这些函数，但不知道如何测试。

我只是以某种方式开始了以下代码：

  1. package sessrage
  3. /*
  4.  * 将数据保存到Redis数据库。通常情况下，数据只在请求期间有效。在Redis中使用哈希数据类型。
  5.  */
  7. import (
  8. 	"../context"
  9. 	"github.com/garyburd/redigo/redis"
  10. 	"net/http"
  11. )
  13. const (
  14. 	protocol string = "tcp"
  15. 	port     string = ":6379"
  16. )
  18. func connectAndCloseRedis(connectCall func(con redis.Conn)) {
  20. 	c, err := redis.Dial("tcp", ":6379")
  21. 	defer c.Close()
  22. 	if err != nil {
  23. 		panic(err.Error())
  24. 	}
  25. 	connectCall(c)
  26. }
  28. func PostSessionData(r *http.Request, key, value string) {
  30. 	go connectAndCloseRedis(func(con redis.Conn) {
  31. 		sessionId := context.Get(r, context.JwtId).(string)
  32. 		con.Do("HMSET", sessionId, key, value)
  33. 	})
  34. }
  36. func GetSessionData(r *http.Request, key string) interface{} {
  38. 	var result interface{}
  40. 	sessionId := context.Get(r, context.JwtId).(string)
  41. 	reply, _ := redis.Values(c.Do("HMGET", sessionId, key))
  42. 	redis.Scan(reply, &result)
  43. 	return result
  44. }

测试文件如下：

  1. package sessrage
  3. import (
  4. 	//"fmt"
  5. 	"../context"
  6. 	. "github.com/smartystreets/goconvey/convey"
  7. 	"github.com/stretchr/testify/assert"
  8. 	"net/http"
  9. 	"net/http/httptest"
  10. 	"testing"
  11. 	"time"
  12. )
  14. var server *httptest.Server
  15. var glrw http.ResponseWriter
  16. var glr *http.Request
  18. func init() {
  19. 	server = httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  20. 		glrw = rw
  21. 		glr = r
  23. 		context.Set(glr, context.JwtId, "TestId")
  24. 	}))
  26. }
  28. func TestPostAndGetSession(t *testing.T) {
  30. 	Convey("POST and GET data on redis.", t, func() {
  32. 		PostSessionData(glr, "key1", "value1")
  34. 		time.Sleep(time.Second * 10)
  35. 		v := GetSessionData(glr, "key1")
  37. 		assert.Equal(t, "value1", v)
  38. 	})
  39. }

当我尝试运行测试时，我得到以下错误：

  1. 无法加载包：......./sessrage.go:10:2: 非本地包中的本地导入 "../context"

而context包的代码如下：

  1. package context
  3. import (
  4. 	"github.com/gorilla/context"
  5. 	"net/http"
  6. )
  8. type contextKey int
  10. const (
  11. 	LanguageId contextKey = iota
  12. 	JwtId
  13. )
  15. func Get(r *http.Request, key interface{}) interface{} {
  16. 	return context.Get(r, key)
  17. }
  19. func Set(r *http.Request, key, val interface{}) {
  20. 	context.Set(r, key, val)
  21. }

我做错了什么？

这是我第一次在与HTTP一起测试代码。测试似乎非常困难。

英文:

I wrote a functions that save data into redis database server. The challenge is that I want to test these functions and do not know how to test it.

I just start somehow with

Functions

  1. package sessrage
  3. /*
  4.  * Save data into redis database. In the common case,
  5.  * the data will be only valid during a request. Use
  6.  * hash datatype in redis.
  7.  */
  9. import (
  10. 	"../context"
  11. 	"github.com/garyburd/redigo/redis"
  12. 	"net/http"
  13. )
  15. const (
  16. 	protocol string = "tcp"
  17. 	port     string = ":6379"
  18. )
  20. func connectAndCloseRedis(connectCall func(con redis.Conn)) {
  22. 	c, err := redis.Dial("tcp", ":6379")
  23. 	defer c.Close()
  24. 	if err != nil {
  25. 		panic(err.Error())
  26. 	}
  27. 	connectCall(c)
  28. }
  30. func PostSessionData(r *http.Request, key, value string) {
  32. 	go connectAndCloseRedis(func(con redis.Conn) {
  33. 		sessionId := context.Get(r, context.JwtId).(string)
  34. 		con.Do("HMSET", sessionId, key, value)
  35. 	})
  36. }
  38. func GetSessionData(r *http.Request, key string) interface{} {
  40. 	var result interface{}
  42. 	sessionId := context.Get(r, context.JwtId).(string)
  43. 	reply, _ := redis.Values(c.Do("HMGET", sessionId, key))
  44. 	redis.Scan(reply, &result)
  45. 	return result
  46. }

and the test file

  1. package sessrage
  3. import (
  4. 	//"fmt"
  5. 	"../context"
  6. 	. "github.com/smartystreets/goconvey/convey"
  7. 	"github.com/stretchr/testify/assert"
  8. 	"net/http"
  9. 	"net/http/httptest"
  10. 	"testing"
  11. 	"time"
  12. )
  14. var server *httptest.Server
  15. var glrw http.ResponseWriter
  16. var glr *http.Request
  18. func init() {
  19. 	server = httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
  20. 		glrw = rw
  21. 		glr = r
  23. 		context.Set(glr, context.JwtId, "TestId")
  24. 	}))
  26. }
  28. func TestPostAndGetSession(t *testing.T) {
  30. 	Convey("POST and GET data on redis.", t, func() {
  32. 		PostSessionData(glr, "key1", "value1")
  34. 		time.Sleep(time.Second * 10)
  35. 		v := GetSessionData(glr, "key1")
  37. 		assert.Equal(t, "value1", v)
  38. 	})
  39. }

when I try to run the test I've got

  1. an't load package: ......./sessrage.go:10:2: local import "../context" in non-local package

and the context package looks like

  1. package context
  3. import (
  4. 	"github.com/gorilla/context"
  5. 	"net/http"
  6. )
  8. type contextKey int
  10. const (
  11. 	LanguageId contextKey = iota
  12. 	JwtId
  13. )
  15. func Get(r *http.Request, key interface{}) interface{} {
  16. 	return context.Get(r, key)
  17. }
  19. func Set(r *http.Request, key, val interface{}) {
  20. 	context.Set(r, key, val)
  21. }

What do I wrong?

That is the first time, I am testing code in conjunction with http. It seems to be very hard to test.

答案1

得分: 1

有几个问题：

  • 不要使用相对导入路径。

  • 在每个操作中使用一个池，而不是每次都拨号到redis。

  • 在PostSessionData匿名函数中的sessionId := context.Get(r, context.JwtId).(string)调用可能会失败，如果mux或调用链中的其他高级组件在goroutine运行之前清除了Gorilla上下文。改为使用以下代码：

    1.   func PostSessionData(r *http.Request, key, value string) {
    2.       c := pool.Get()
    3.       defer c.Close()
    4.       sessionId := context.Get(r, context.JwtId).(string)
    5.       if err := c.Do("HMSET", sessionId, key, value); err != nil {
    6.          // 处理错误
    7.       }
    8.   }
英文:

There are a few issues:

  • Don't use relative import paths.

  • Use a pool instead of dialing redis on every action.

  • The call to sessionId := context.Get(r, context.JwtId).(string) in the PostSessionData anonymous function can fail if the mux or something higher in the call chain clears the Gorilla context before the goroutine runs. Do this instead:

    1.   func PostSessionData(r *http.Request, key, value string) {
    2.       c := pool.Get()
    3.       defer c.Close()
    4.       sessionId := context.Get(r, context.JwtId).(string)
    5.       if err := c.Do("HMSET", sessionId, key, value); err != nil {
    6.          // handle error
    7.       }
    8.   }

huangapple
  • 本文由 发表于 2014年10月17日 03:18:29
  • 转载请务必保留本文链接：https://go.coder-hub.com/26412201.html
  • go
匿名

发表评论

匿名网友

:?: :razz: :sad: :evil: :!: :smile: :oops: :grin: :eek: :shock: :???: :cool: :lol: :mad: :twisted: :roll: :wink: :idea: :arrow: :neutral: :cry: :mrgreen:

确定