How can I add products on backend from a Wishlist to cart

I have been working on developing am API which basically adds/updates all the products from a wishlist to the user's cart.

The requirements of the API are as follows:

1. the API should take input of the ID of the wishlist and add all its products to cart
2. If the products stored in the wishlist already exists on cart then the cart quantity is to be updated with the sum of both the quantity present on wishlist and the cart.
3. the wishlist is to be retained after adding the products.

The logic that I had implemented deals with a 2 nested for loop, one loops the wishlist entries and the other loops the cart entries if the cart isn't empty. This logic works well for adding a product but I am having trouble updating the products.

When I hit the API on an empty cart I see no issue all the products were added perfectly, but when I try to hit the API again the only one item of the cart is getting updated while the others stay the same, this is happening cause when the index of the wishlist is incrementing to check for the next product the previously updated products which were updated to the sum of the both quantities are now overridden by the addToCart() method.

like if there are 2 same products on the wishlist and the cart namely Product A and Product B on the two for loops

There will be four conditions

sl cart   wishlist   operation
1   A         A       update
2   A         B        add
3   B         A        add
4   B         B       update

For case 1 the product gets updated at first but the is getting overridden by the addToCart method in the second iteration.

How do I solve this?

Suggestions to other type of implementation is also welcome but I can't change most of the pre-existing methods such as AddToCart() or UpdateCart().

The implementation

public void addAllToCart(String wishListId) 
{
    //code for finding the wishlist by ID saves the wishlist on wishlist of type WishListModel
    //code for getting session cart saves on cart of type CartModel
    if (CollectionUtils.isNotEmpty(wishlist.getEntries())) 
    {
        for (WishListEntryModel wishListEntry : wishlist.getEntries()) 
        {
            checkInCartEntry(wishListEntry, cart.getEntries());
        }
    }
}

private void checkInCartEntry(WishListEntryModel wishListEntry, List<AbstractOrderEntryModel> cartEntries)
{
    if (CollectionUtils.isEmpty(cartEntries))
    {
        addToCart(wishListEntry);
    }
    else
    {
        for (AbstractOrderEntryModel cartEntry : cartEntries) 
        {
            if (wishListEntry.getProduct().getCode().equalsIgnoreCase(cartEntry.getProduct().getCode())) 
            {
                updateCartEntry(cartEntry.getEntryNumber, wishlist.getQuantity+cartEntry.getQuantity);
            } 
            else 
            {
                addToCart(wishListEntry);
            }
        }
    }
}

There is a mistake in your loops so the nested one does not ever break. Let's assume you have one product in a wish list and four products in a cart. In this setup addToCart(wishListEntry) method will be called four times. Also if there is a possibility to have the same product in a wish list multiple times it would make sense to change the implementation so there were two separate loops which would populate a map like <productCode, finalQuantity> and then iterate over the map and finally call expensive add/update operation just one time per each product.

I think that the main problem is that you don't refresh the cart after manipulating it's entries using de.hybris.platform.commercefacades.order.CartFacade methods.

For example let's assume that you have a simple cart:

• 1x Product A (#1)

and a wishlist:

• 1x Product A (#1)
• 1x Product A (#2)

In such scenario when you iterate over wishlist entries you always update cart entry to a value wishlist.getQuantity+cartEntry.getQuantity where cartEntry.getQuantity always returns the quantity of 1 (because this was the cart quantity at the beginning of the operation).

So you have something like this:

1. Load cart containing 1xProduct A into cart
2. Iterate over wishlist entries
   1. For wishlist entry #1 - iterate over cart.getEntries():
      1. For cart entry #1 - you have a matching entry so call updateCartEntry using the quantity of cart entry #1 of the cart loaded in step 1
   2. For wishlist entry #2 - iterate over cart.getEntries():
      1. For cart entry #1 - you have a matching entry so call updateCartEntry using the quantity of cart entry #1 of the cart loaded in step 1 -> the problem is that this value is stale, it was not updated by updateCartEntry in step 2.1.1

To avoid this you could:

1. Somehow update the quantities of entries of cart loaded in step 1
2. Avoid updating the same cart entry multiple times by either:
   1. Disallowing multiple entries containing the same product
   2. Or merging entries containing the same product at the beginning just as Maksym Kosenko suggested in his answer.

Thanks for all the comments and answers.
I solved this issue by separating adding, and updating tasks in the methods.
Nested loops which I was using earlier as correctly pointed out by @Mak in their answer never break thus causing the addToCart() method to override the manipulations made earlier.
but instead of using a map, I used a more simple solution and did the following:

1. Called the session cart
2. Copied the cart in another variable
3. Called the addToCart() method and overwrite all the cart entries with the wishlist entry
4. After overwriting the cart with the shopping list entries, I loop through the copy of the cart and the cart and update the product which are same.

The code is below

public void addAllToCart(String wishListId) {
    WishListModel wishList = findByWishlistId(wishListId)
    CartModel cart = cartService.getSessionCart();
    CartModel tempCart = copyOf(cart);
    if(CollectionUtils.isNotEmpty(wishList.getEntries())) {
        for (WishListEntryModel wishListEntry : wishlist.getEntries()) {
            cartFacade.addToCart(wishListEntry);
        }
        if(Objects.nonNull(tempCart)){
            for (AbstractOrderEntryModel tempCartEntry : tempCart.getEntries()) {
                checkInCartEntry(tempCartEntry, cart.getEntries());
            }
        }
    }
}
private void checkInCartEntry(AbstractOrderEntryModel tempCartEntry, List<AbstractOrderEntryModel> cartEntries) throws CommerceCartModificationException {
    for (AbstractOrderEntryModel cartEntry : cartEntries) {
        if(!tempCartEntry.getProduct().getCode().isEmpty() &&  !cartEntry.getProduct().getCode().isEmpty() && (tempCartEntry.getProduct().getCode().equalsIgnoreCase(cartEntry.getProduct().getCode()))) {
                cartFacade.updateCartEntry(cartEntry.getEntryNumber(), cartEntry.getQuantity());

        }
    }
}