问题

I have reviewed your code and your goals for building a trading model. Here are some suggestions to optimize and improve the code:

Modularize Code: Break down your code into smaller, reusable functions or classes. This makes it easier to understand, test, and maintain. For example, you can create separate functions for calculating metrics, finding pivot highs and lows, and determining trade entries and exits.
Use Constants: Define constants for parameters such as stop loss and take profit percentages. This makes it easier to adjust these values in the future.
Parameter Tuning: Consider using a parameter tuning approach to find the best values for parameters like the length of the moving average or the percentage for stop loss and take profit. This can be done using techniques like grid search or genetic algorithms.
Backtesting: Implement a backtesting framework to evaluate the performance of your trading strategy. This will help you validate whether your model meets the performance goals you've set.
Portfolio Management: Incorporate portfolio management techniques if you plan to trade multiple assets simultaneously. This might involve position sizing, risk management, and asset allocation strategies.
Error Handling: Implement error handling to gracefully handle exceptions or unexpected data. This ensures that your code doesn't crash in real-world scenarios.
Documentation: Add comments and documentation to explain the purpose of each function and the overall workflow. This makes it easier for others (and your future self) to understand and modify the code.
Optimization: Depending on the size of your data, you may want to optimize certain parts of your code for performance. For example, you can explore using NumPy for vectorized calculations.
Visualization: Improve the clarity of your plots by adding labels, titles, and legends. Visualizations are essential for understanding the trading strategy's behavior.
Testing and Validation: Ensure that your model is thoroughly tested and validated on historical data. Be cautious of overfitting, where the model performs well on training data but poorly on new data.
Risk Management: Implement robust risk management strategies, including position sizing based on risk tolerance and portfolio diversification.
Alternative Approaches: Consider exploring alternative trading strategies or machine learning techniques that may better suit your goals.
Data Quality: Ensure that your historical price and volume data are of high quality and free from errors or gaps.
Real-time Integration: If you plan to use this model in a live trading environment, you'll need to integrate it with real-time data feeds and trading APIs. This requires additional considerations for order execution, slippage, and latency.
Monitoring and Maintenance: Regularly monitor the performance of your trading model and be prepared to adapt to changing market conditions. Maintenance is an ongoing process.

Please note that building a successful trading model is a complex and challenging task, and it often requires a combination of domain expertise, data analysis, and continuous refinement. Additionally, it's essential to be aware of the risks involved in algorithmic trading and to use risk management strategies to protect your capital.

英文:

I'm trying to build a model using historical price and volume data.

Decision Variables

The model should be able to decide:

When to enter a trade
What type of trade to enter (Long/Short)
How much SL and TP to keep for a trade
When to exit a trade

Things to keep in mind

The model should at no point take into consideration any future price or volume data when making a trading decision. E.g., a decision to enter trade should be purely made on the price or volume data from the past, it should have no influence of future. This is to simulate the real-world where future price or volume movements are not available anyway.
The model can use multiple validations to achieve the goals
Multiple time horizons can be looked at (e.g., 1-min candles, 2-min candles, 5-mins, etc.).

Goals

The overall targets to achieve through the model are:

Daily cumulative trading returns: >= 10% (cumulative = sum of all trades)

Sharpe Ratio: >= 3.0
Sortino Ratio: >= 5.0
Profit Factor: >= 2.0
Win Rate: >=75% (no. of positive trades / total trades)

Approach 1 (using TA-Lib):

import talib as ta
import math
import matplotlib.pyplot as plt

# Parameters
length = 14
k = 1.0
method = &#39;Atr&#39;
show = False

# Data
# Replace [...] with your price and volume data
close = [...]
high = [...]
low = [...]
volume = [...]

# Calculate pivot highs and lows
ph = find_pivot_highs(high, length)
pl = find_pivot_lows(low, length)


def find_pivot_highs(data, length):
    pivot_highs = []
    for i in range(length, len(data) - length):
        if (
            data[i] &gt; max(data[i - length : i])
            and data[i] &gt; max(data[i + 1 : i + length + 1])
        ):
            pivot_highs.append(i)
    return pivot_highs


def find_pivot_lows(data, length):
    pivot_lows = []
    for i in range(length, len(data) - length):
        if (
            data[i] &lt; min(data[i - length : i])
            and data[i] &lt; min(data[i + 1 : i + length + 1])
        ):
            pivot_lows.append(i)
    return pivot_lows


# Calculate slope
def calculate_slope():
    if method == &#39;Atr&#39;:
        return ta.ATR(high, low, close, length) / length * k
    elif method == &#39;Stdev&#39;:
        return ta.STDDEV(src, length) / length * k
    elif method == &#39;Linreg&#39;:
        sma1 = ta.SMA(src * n, length)
        sma2 = ta.SMA(src, length)
        return math.fabs(sma1 - sma2 * ta.SMA(n, length)) / ta.VAR(n, length) / 2 * k


slope = calculate_slope()

slope_ph = [slope[i] if i in ph else slope_ph[i-1] for i in range(len(close))]
slope_pl = [slope[i] if i in pl else slope_pl[i-1] for i in range(len(close))]

upper = [ph[i] if i in ph else upper[i-1] - slope_ph[i] for i in range(len(close))]
lower = [pl[i] if i in pl else lower[i-1] + slope_pl[i] for i in range(len(close))]

# ----
single_upper = [0] * len(close)
single_lower = [0] * len(close)

for i in range(length, len(close)):
    if close[i] &gt; upper[i-length]:
        single_upper[i] = 1
    elif i in ph:
        single_upper[i] = single_upper[i-1]

    if close[i] &lt; lower[i-length]:
        single_lower[i] = 1
    elif i in pl:
        single_lower[i] = single_lower[i-1]

upper_breakout = [
    single_upper[i-1] and close[i] &gt; upper[i] and (show or close[i] &gt; close[i-length])
    for i in range(len(close))
]

lower_breakout = [
    single_lower[i-1] and close[i] &lt; lower[i] and (show or close[i] &lt; close[i-length])
    for i in range(len(close))
]

# Trading strategy
trades = []
trade_type = None
entry_price = None
stop_loss = None
take_profit = None

for i in range(len(close)):
    if trade_type is None:
        if upper_breakout[i]:
            trade_type = &#39;Long&#39;
            entry_price = close[i]
            stop_loss = entry_price - 0.02 * entry_price  # Example stop loss calculation
            take_profit = entry_price + 0.03 * entry_price  # Example take profit calculation
        elif lower_breakout[i]:
            trade_type = &#39;Short&#39;
            entry_price = close[i]
            stop_loss = entry_price + 0.02 * entry_price  # Example stop loss calculation
            take_profit = entry_price - 0.03 * entry_price  # Example take profit calculation
    else:
        if trade_type == &#39;Long&#39;:
            if close[i] &lt;= stop_loss or close[i] &gt;= take_profit:
                trades.append((entry_price, stop_loss, take_profit))
                trade_type = None
                entry_price = None
                stop_loss = None
                take_profit = None
        elif trade_type == &#39;Short&#39;:
            if close[i] &gt;= stop_loss or close[i] &lt;= take_profit:
                trades.append((entry_price, stop_loss, take_profit))
                trade_type = None
                entry_price = None
                stop_loss = None
                take_profit = None

# Calculate metrics
total_trades = len(trades)
positive_trades = sum(1 for t in trades if t[2] &gt; t[0])
win_rate = positive_trades / total_trades if total_trades &gt; 0 else 0

cumulative_returns = sum((t[2] - t[0]) / t[0] for t in trades)
sharpe_ratio = (cumulative_returns - 0.01) / (cumulative_returns.std() + 1e-9)
sortino_ratio = (cumulative_returns - 0.01) / (cumulative_returns[cumulative_returns &lt; 0].std() + 1e-9)
profit_factor = sum(t[2] - t[0] for t in trades if t[2] &gt; t[0]) / abs(sum(t[2] - t[0] for t in trades if t[2] &lt; t[0]))

# Print metrics
print(f&quot;Total Trades: {total_trades}&quot;)
print(f&quot;Positive Trades: {positive_trades}&quot;)
print(f&quot;Win Rate: {win_rate * 100}%&quot;)
print(f&quot;Cumulative Returns: {cumulative_returns * 100}%&quot;)
print(f&quot;Sharpe Ratio: {sharpe_ratio}&quot;)
print(f&quot;Sortino Ratio: {sortino_ratio}&quot;)
print(f&quot;Profit Factor: {profit_factor}&quot;)

# Plotting
plt.plot(close[length:], label=&#39;Closing Price&#39;)
plt.plot(upper[length:], label=&#39;Upper Trendline&#39;, color=&#39;#26a69a&#39;)
plt.plot(lower[length:], label=&#39;Lower Trendline&#39;, color=&#39;#ef5350&#39;)

for i in range(len(close)):
    if upper_breakout[i]:
        plt.scatter(i, close[i-length], marker=&#39;^&#39;, color=&#39;r&#39;, label=&#39;Upper Break&#39;)
    if lower_breakout[i]:
        plt.scatter(i, close[i-length], marker=&#39;v&#39;, color=&#39;g&#39;, label=&#39;Lower Break&#39;)

plt.legend()
plt.show()

Approach 2 (using pandas_ta):

import pandas as pd
import pandas_ta as ta
import matplotlib.pyplot as plt
import numpy as np

# Load your price data into a pandas DataFrame
data = pd.read_csv(&#39;your_data.csv&#39;)
close = data[&#39;close&#39;]
high = data[&#39;high&#39;]
low = data[&#39;low&#39;]

length = 14
k = 1.0
method = &#39;Atr&#39;
show = False

# Calculate the indicators using pandas-ta
data[&#39;atr&#39;] = ta.atr(high, low, close, length)
data[&#39;stddev&#39;] = ta.stddev(close, length)
data[&#39;sma1&#39;] = ta.sma(close, length)
data[&#39;sma2&#39;] = ta.sma(close, length)
data[&#39;var&#39;] = ta.var(close, length)
data[&#39;n&#39;] = data.index

data[&#39;slope&#39;] = 0.0
data[&#39;slope&#39;] = np.where(method == &#39;Atr&#39;, data[&#39;atr&#39;] / length * k,
                         np.where(method == &#39;Stdev&#39;, data[&#39;stddev&#39;] / length * k,
                                  np.where(method == &#39;Linreg&#39;, data[&#39;sma1&#39;] - data[&#39;sma2&#39;] * data[&#39;n&#39;] / data[&#39;var&#39;] / 2 * k)))
#data.loc[method == &#39;Atr&#39;, &#39;slope&#39;] = data[&#39;atr&#39;] / length * k
#data.loc[method == &#39;Stdev&#39;, &#39;slope&#39;] = data[&#39;stddev&#39;] / length * k
#data.loc[method == &#39;Linreg&#39;, &#39;slope&#39;] = (data[&#39;sma1&#39;] - data[&#39;sma2&#39;] * data[&#39;n&#39;]) / data[&#39;var&#39;] / 2 * k

# Find pivot highs and lows
data[&#39;ph&#39;] = ta.pivot_high(high, length)
data[&#39;pl&#39;] = ta.pivot_low(low, length)

data[&#39;slope_ph&#39;] = data[&#39;slope&#39;].where(data.index.isin(data[&#39;ph&#39;])).ffill()
data[&#39;slope_pl&#39;] = data[&#39;slope&#39;].where(data.index.isin(data[&#39;pl&#39;])).ffill()

data[&#39;upper&#39;] = data[&#39;ph&#39;].where(data.index.isin(data[&#39;ph&#39;])).ffill() - data[&#39;slope_ph&#39;]
data[&#39;lower&#39;] = data[&#39;pl&#39;].where(data.index.isin(data[&#39;pl&#39;])).ffill() + data[&#39;slope_pl&#39;]

# Determine trade entries and exits
data[&#39;trade_type&#39;] = None
data[&#39;entry_price&#39;] = None
data[&#39;stop_loss&#39;] = None
data[&#39;take_profit&#39;] = None

for i in range(length, len(data)):
    if data[&#39;close&#39;][i] &gt; data[&#39;upper&#39;][i-length]:
        data[&#39;trade_type&#39;][i] = &#39;Long&#39;
        data[&#39;entry_price&#39;][i] = data[&#39;close&#39;][i]
        data[&#39;stop_loss&#39;][i] = data[&#39;entry_price&#39;][i] - 0.02 * data[&#39;entry_price&#39;][i]
        data[&#39;take_profit&#39;][i] = data[&#39;entry_price&#39;][i] + 0.03 * data[&#39;entry_price&#39;][i]
    elif data[&#39;close&#39;][i] &lt; data[&#39;lower&#39;][i-length]:
        data[&#39;trade_type&#39;][i] = &#39;Short&#39;
        data[&#39;entry_price&#39;][i] = data[&#39;close&#39;][i]
        data[&#39;stop_loss&#39;][i] = data[&#39;entry_price&#39;][i] + 0.02 * data[&#39;entry_price&#39;][i]
        data[&#39;take_profit&#39;][i] = data[&#39;entry_price&#39;][i] - 0.03 * data[&#39;entry_price&#39;][i]

data[&#39;trade_type&#39;] = data[&#39;trade_type&#39;].ffill()
data[&#39;entry_price&#39;] = data[&#39;entry_price&#39;].ffill()
data[&#39;stop_loss&#39;] = data[&#39;stop_loss&#39;].ffill()
data[&#39;take_profit&#39;] = data[&#39;take_profit&#39;].ffill()

data[&#39;exit_trade&#39;] = False
for i in range(length, len(data)):
    if (
        (data[&#39;trade_type&#39;][i] == &#39;Long&#39; and data[&#39;low&#39;][i] &lt; data[&#39;stop_loss&#39;][i]) or
        (data[&#39;trade_type&#39;][i] == &#39;Short&#39; and data[&#39;high&#39;][i] &gt; data[&#39;stop_loss&#39;][i])
    ):
        data[&#39;exit_trade&#39;][i] = True

# Calculate trading metrics
total_trades = len(data[data[&#39;entry_price&#39;].notnull()])
positive_trades = len(data[(data[&#39;entry_price&#39;].notnull()) &amp; (data[&#39;close&#39;] &gt; data[&#39;entry_price&#39;])])
win_rate = positive_trades / total_trades if total_trades &gt; 0 else 0.0

# Plotting
plt.plot(data[&#39;close&#39;][length:], label=&#39;Closing Price&#39;)
plt.plot(data[&#39;upper&#39;][length:], label=&#39;Upper Trendline&#39;, color=&#39;#26a69a&#39;)
plt.plot(data[&#39;lower&#39;][length:], label=&#39;Lower Trendline&#39;, color=&#39;#ef5350&#39;)

for i in range(len(data)):
    if not pd.isnull(data[&#39;entry_price&#39;][i]):
        if data[&#39;trade_type&#39;][i] == &#39;Long&#39;:
            plt.scatter(i, data[&#39;entry_price&#39;][i], marker=&#39;^&#39;, color=&#39;r&#39;, label=&#39;Long Entry&#39;)
        else:
            plt.scatter(i, data[&#39;entry_price&#39;][i], marker=&#39;v&#39;, color=&#39;g&#39;, label=&#39;Short Entry&#39;)
    if data[&#39;exit_trade&#39;][i]:
        plt.scatter(i, data[&#39;stop_loss&#39;][i], marker=&#39;x&#39;, color=&#39;b&#39;, label=&#39;Exit&#39;)

plt.legend()
plt.show()

I need suggestions about how to incorporate all the goals and make the code, more optimized and better.

Cheers!

答案1

得分: 1

尝试使用 pandas-ta 这个库，它比 ta-lib 更轻量和更快。

英文:

Try using pands-ta the library is lighter and faster than ta-lib

通过集体智慧和协作来改善编程学习和解决问题的方式。致力于成为全球开发者共同参与的知识库，让每个人都能够通过互相帮助和分享经验来进步。

“突破策略的交易模型”

问题

答案1

if first value is zero in one dataframe set previous values to 1 in another dataframe on condition

你可以使用循环来基于条件在Pandas数据框中进行列的子集化。

处理Python 3中的MySQL结果

How to add a row of coefficients to a matrix and compute differences between rows using sympy and fractions in Python?

What's the correct way to type hint an empty list as a literal in python?

如何在Highcharts Gantt中更改本地化的星期名称

如何在同一个流中使用多个过滤器和映射函数？

如何使用Map/Set来将代码优化到O(n)？

.NET MAUI Android在GitHub Actions上构建失败，错误代码为1。

如何在Playwright视觉比较中屏蔽多个定位器？

在C++中，可以使用可变模板参数来检索类型的内部类型。

selenium.common.exceptions.StaleElementReferenceException: Message: stale element reference: stale element not found

Creating and opening a URL to log in to Website via Basic Auth with Robot Framework/Selenium (Python)

AG Grid 在上下文菜单中以大文本形式打开

发表评论