英文:
Excel macro trying to make changes after macro is finished and worksheet is locked
问题
I've been protecting an Excel document from being edited since users keep breaking it. While this Excel document shouldn't be able to be broken this easily in the first place; it is outside my scope to fix it. I am just here to provide a temporary solution.
The issue
When users execute the refresh macro, it locks the worksheet too quickly, resulting in an error that it can't make changes since the cell or chart is protected. The strange thing is that the module for locking the sheet only gets executed at the end. Does anyone know why this is happening?
My Code
Sub Verversen()
'
' Verversen Macro
'
Call Module11.unlockcells
Range("J12").Select
ActiveWorkbook.RefreshAll
ActiveWorkbook.Worksheets("Batch Checker").ListObjects("AllStockSQL").Sort. _
SortFields.Clear
ActiveWorkbook.Worksheets("Batch Checker").ListObjects("AllStockSQL").Sort. _
SortFields.Add Key:=Range("AllStockSQL[[#Headers],[#Data],[Batch]]"), SortOn _
:=xlSortOnValues, Order:=xlAscending, DataOption:=xlSortNormal
With ActiveWorkbook.Worksheets("Batch Checker").ListObjects("AllStockSQL").Sort
.Header = xlYes
.MatchCase = False
.Orientation = xlTopToBottom
.SortMethod = xlPinYin
.Apply
End With
'Call Module12.Refresh_All_Data_Connections
' Range("G31").Select
ActiveSheet.PivotTables("PivotTable4").PivotCache.Refresh
ActiveSheet.PivotTables("PivotTable5").PivotCache.Refresh
' ActiveWorkbook.RefreshAll
Call Module9.lockcells
End Sub
Module 9
Public Sub lockcells()
Worksheets("Batch Checker").Range("F4:N200").Locked = True
ActiveSheet.Protect Password:="temp", UserInterfaceOnly:=True, AllowUsingPivotTables:=True
End Sub
Module 11
Public Sub unlockcells()
ActiveSheet.Unprotect Password:="temp"
Worksheets("Batch Checker").Range("F4:N200").Locked = False
End Sub
I've tried putting in a wait timer; I've turned off the background refresh except the option "Refresh this connection on Refresh All"; I've tried to put DoEvents before; I've tried creating different modules which I'd call in. Nothing works, possibly I am overlooking something simple as I am quite a novice in VBA.
英文:
I've been protecting a Excel document from being edited since users keep breaking it.
While this excel document shouldn't be able to be broken this easily in the first place; it is outside my scope to fix it. I am just here to provide a temporary solution.
The issue
When users execute the refresh macro it locks the worksheet to fast; in turn it gives a the error that it can't make changes since the cell or chart is protected.
Strange thing is that the module for locking the sheet only gets executed at the end.
Anyone knows why this is happening?
My Code
Sub Verversen()
'
' Verversen Macro
'
Call Module11.unlockcells
Range("J12").Select
ActiveWorkbook.RefreshAll
ActiveWorkbook.Worksheets("Batch Checker").ListObjects("AllStockSQL").Sort. _
SortFields.Clear
ActiveWorkbook.Worksheets("Batch Checker").ListObjects("AllStockSQL").Sort. _
SortFields.Add Key:=Range("AllStockSQL[[#Headers],[#Data],[Batch]]"), SortOn _
:=xlSortOnValues, Order:=xlAscending, DataOption:=xlSortNormal
With ActiveWorkbook.Worksheets("Batch Checker").ListObjects("AllStockSQL").Sort
.Header = xlYes
.MatchCase = False
.Orientation = xlTopToBottom
.SortMethod = xlPinYin
.Apply
End With
'Call Module12.Refresh_All_Data_Connections
' Range("G31").Select
ActiveSheet.PivotTables("PivotTable4").PivotCache.Refresh
ActiveSheet.PivotTables("PivotTable5").PivotCache.Refresh
' ActiveWorkbook.RefreshAll
Call Module9.lockcells
End Sub
Module 9
Public Sub lockcells()
Worksheets("Batch Checker").Range("F4:N200").Locked = True
ActiveSheet.Protect Password:="temp", UserInterfaceOnly:=True, AllowUsingPivotTables:=True
End Sub
Module 11
Public Sub unlockcells()
ActiveSheet.UNprotect Password:="temp"
Worksheets("Batch Checker").Range("F4:N200").Locked = False
End Sub
I've tried putting in a wait timer;
I've turned off the background refresh except option Refresh this connection on Refresh All;
I've tried to put DoEvent before;
I've tried creating different modules which I'd call in
Nothing works, possibly I am overlooking something simple as I am quite a novice in VBA.
答案1
得分: 0
以下是翻译好的部分:
解决方案由Emilio Silva提供。
在锁定模块之前,我放置了Application.CalculateFull和Application.CalculateUntilAsyncQueriesDone。
模块9
Public Sub lockcells()
Application.CalculateFull
Application.CalculateUntilAsyncQueriesDone
Worksheets("Batch Checker").Range("A4:N200").Locked = True
Worksheets("Batch Checker").Protect Password:="已编辑", UserInterfaceOnly:=True, AllowUsingPivotTables:=True
End Sub
英文:
Solution was given by Emilio Silva.
In the lock module before it locks I put Application.CalculateFull and Application.CalculateUntilAsyncQueriesDone.
Module 9
Public Sub lockcells()
Application.CalculateFull
Application.CalculateUntilAsyncQueriesDone
Worksheets("Batch Checker").Range("A4:N200").Locked = True
Worksheets("Batch Checker").Protect Password:="REDacted", UserInterfaceOnly:=True, AllowUsingPivotTables:=True
End Sub
通过集体智慧和协作来改善编程学习和解决问题的方式。致力于成为全球开发者共同参与的知识库,让每个人都能够通过互相帮助和分享经验来进步。
评论