减少筛选JS对象的函数

huangapple
go评论96阅读模式
英文:

Reducing the function that filters the JS object

问题

Sure, here's the translated code portion you requested:

  1. 我有一个类似这样的JS对象：
  3. {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26", "settings":"[{"ip":""}]"}
  5. 我想创建一个函数，它返回这样一个对象，不包含字符串数组字段，例如**"settings":"[{"ip":""}]"**，并且如果这个数组只包含一个元素，并且这个对象只包含一个键值对，值为空字符串。
  7. 期望的结果是：
  9. {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26"}
  11. 不应该过滤的数组：
  13. {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26", "settings":"[{"ip":"33333not empty"}]"}
  14. 或者：
  16. {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26", "settings":"[{"ip":"345", "dns": "address"}]"}
  18. 我编写了以下函数：

Please note that I've translated the code portion as requested, but I haven't provided any answers to your questions or comments in the code. If you need further assistance or have questions about the code, please let me know.

英文:

I have a JS object like this:

  1. {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26", "settings":"[{"ip":""}]"}

I would like to create a function which returns such object without field which is string-array "settings":"[{"ip":""}]" and if this array contains only one element and if this object contains only one key-value pair with value of empty string.

Desired result is:

  1. {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26"}

Arrays not to be filtered:

  1. {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26", "settings":"[{"ip":"33333not empty"}]"}

or:

  1. {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26", "settings":"[{"ip":"345", "dns": "address"}]"}

I wrote the following function:

  1.     function filterArrayFields(values) {
  2. const result = {};
  3. const fieldNames = Object.keys(values);
  4. fieldNames.forEach((fieldName) => {
  5. if (typeof values[fieldName] !== 'string') {
  6. result[fieldName] = values[fieldName];
  7. return;
  8. }
  9. try {
  10. const parsedValue = JSON.parse(values[fieldName]);
  11. if (!Array.isArray(parsedValue)) {
  12. result[fieldName] = values[fieldName];
  13. return;
  14. }
  15. if (Array.isArray(parsedValue) && parsedValue.length > 1) {
  16. result[fieldName] = values[fieldName];
  17. return;
  18. }
  19. if (Array.isArray(parsedValue) && parsedValue.length === 1) {
  20. const arrayTypeFieldValue = parsedValue[0];
  21. const [arrayTypeFieldValueName] = Object.keys(arrayTypeFieldValue);
  22. if (arrayTypeFieldValue[arrayTypeFieldValueName] !== '') {
  23. result[fieldName] = values[fieldName];
  24. return;
  25. }
  26. }
  27. } catch (error) {
  28. result[fieldName] = values[fieldName];
  29. }
  30. });
  31. return result;
  32. }

This method is working correctly but it looks like that it is overloaded buy if-s or extra conditions. Is it possible to optimize this function anyhow?

Edit: our target field can have any name, not only 'settings' - 'settings' here is just an example

答案1

得分: 2

我认为你可以通过使用扩展运算符 浅克隆输入对象，并在只有满足条件时有条件地合并设置来显著简化这个部分。

条件测试可以由一个单独的专用函数处理。类似于这样：

  1. function stripEmptySettings(obj) {
  2.   const { settings, ...rest } = obj;
  3.   return {
  4.     ...rest,
  5.     ...stripSettings(JSON.parse(settings)),
  6.   };
  7. }
  9. function stripSettings(settings) {
  10.   if (
  11.     settings?.length === 1
  12.     && Object.keys(settings[0]).length === 1
  13.     && Object.values(settings[0]).every(v => v === '')
  14.   ) {
  15.     return;
  16.   }
  17.   return { settings };
  18. }
  20. const inputs = [
  21.   {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26", "settings":"[{"ip":" "}]"},
  22.   {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26", "settings":"[{"ip":"33333not empty"}]"},
  23.   {"field1":1,"field3":14,"category":9,"completion":null,"creation":"23-04-26", "settings":"[{"ip":"345", "dns": "address"}]"}
  24. ];
  26. const results = inputs.map(stripEmptySettings);
  28. console.log(JSON.stringify(results, null, 3));

希望这可以帮助你。

英文:

I think you could tighten this up significantly by shallow-cloning the input object via the spread operator and conditionally merging the settings back in only if it meets your criteria.

The criteria testing could be handled by a separate dedicated function. Something like this:

<!-- begin snippet: js hide: false console: true babel: false -->

<!-- language: lang-js -->

  1. function stripEmptySettings (obj) {
  2. const { settings, ...rest } = obj;
  3. return {
  4. ...rest,
  5. ...stripSettings(JSON.parse(settings)),
  6. }
  7. }
  8. function stripSettings (settings) {
  9. if (
  10. settings?.length === 1
  11. &amp;&amp; Object.keys(settings[0]).length === 1
  12. &amp;&amp; Object.values(settings[0]).every(v =&gt; v === &#39;&#39;)
  13. ) {
  14. return;
  15. }
  16. return {settings};
  17. }
  18. const inputs = [
  19. {&quot;field1&quot;:1,&quot;field3&quot;:14,&quot;category&quot;:9,&quot;completion&quot;:null,&quot;creation&quot;:&quot;23-04-26&quot;, &quot;settings&quot;:&quot;[{\&quot;ip\&quot;:\&quot;\&quot;}]&quot;},
  20. {&quot;field1&quot;:1,&quot;field3&quot;:14,&quot;category&quot;:9,&quot;completion&quot;:null,&quot;creation&quot;:&quot;23-04-26&quot;, &quot;settings&quot;:&quot;[{\&quot;ip\&quot;:\&quot;33333not empty\&quot;}]&quot;},
  21. {&quot;field1&quot;:1,&quot;field3&quot;:14,&quot;category&quot;:9,&quot;completion&quot;:null,&quot;creation&quot;:&quot;23-04-26&quot;, &quot;settings&quot;:&quot;[{\&quot;ip\&quot;:\&quot;345\&quot;, \&quot;dns\&quot;: \&quot;address\&quot;}]&quot;}
  22. ]
  23. const results = inputs.map(stripEmptySettings);
  24. console.log(JSON.stringify(results, null, 3));

<!-- end snippet -->

答案2

得分: 1

JS有一个内置的筛选函数。对于使用JSON.stringify()和JSON.parse()的设置值，这将是序列化数组的最简单方式。

  1. const filteredList = fieldNames.filter(field => {
  2.   if ("settings" in field) {
  3.     let settings = JSON.parse(field.settings);
  4.     if (
  5.       settings.length > 0 &&
  6.       settings[0]
  7.     ) {
  8.       let nonEmpty = false;
  9.       const keys = Object.keys(settings[0]);
  10.       for (let i = 0; i < keys.length; i++) {
  11.         if (settings[0][keys[i]]) {
  12.           nonEmpty = true;
  13.           break;
  14.         }
  15.       }
  16.       return nonEmpty;
  17.     }
  18.     return false;
  19.   }
  20.   return true;
  21. });
英文:

JS has a builtin filter function. For the settings value using JSON.stringify() and JSON.parse() will be the easiest way to serialize the array

  1. const filteredList = fieldNames.filter(field =&gt; {
  2. if(&quot;settings&quot; in field){
  3. let settings = JSON.parse(field.settings)
  4. if(
  5. settings.length &gt; 0 &amp;&amp;
  6. settings[0]
  7. ){
  8. let nonEmpty = false
  9. const keys = Object.keys(settings[0])
  10. for(let i =0; i &lt; keys.length; i ++){
  11. if(settings[0][keys[i]]){
  12. nonEmpty = true
  13. break
  14. }
  15. }
  16. return nonEmpty
  17. }
  18. return false
  19. }
  20. return true
  21. })

huangapple
  • 本文由 发表于 2023年4月20日 00:18:20
  • 转载请务必保留本文链接：https://go.coder-hub.com/76056774.html
  • algorithm
  • arrays
  • javascript
  • node.js
匿名

发表评论

匿名网友

:?: :razz: :sad: :evil: :!: :smile: :oops: :grin: :eek: :shock: :???: :cool: :lol: :mad: :twisted: :roll: :wink: :idea: :arrow: :neutral: :cry: :mrgreen:

确定