英文:
Errorlevel always returns 0 in a for loop with ping command
问题
我正在尝试创建一个批处理脚本，该脚本将通过主机名ping一台计算机，将IP和域保存到变量中，并显示状态（ON或OFF）。
如何修改此代码以便正确显示状态？
我的代码总是返回ON，即使计算机实际上是OFF。
@echo offsetlocal ENABLEDELAYEDEXPANSIONset hostname=non-existent-hostnameset domain=UNRESOLVEDset ip=UNRESOLVEDfor /f "tokens=2,3 delims= " %%b in ('ping -a -4 -n 1 !hostname! ^| find "Pinging"') do (set domain=%%bset ip=%%c)if errorlevel 1 (echo !hostname! !ip! [!domain!] is OFF) else (echo !hostname! !ip! [!domain!] is ON)pause
注意：以上是您提供的批处理脚本的翻译部分。
英文:
I am trying to create a batch script that will ping a machine by hostname, save ip and domain to a variable and display the state (ON or OFF).
How can i fix this code so it will display the status correctly?
My code always returns ON even if pc is actually OFF.
@echo offsetlocal ENABLEDELAYEDEXPANSIONset hostname=non-existent-hostnameset domain=UNRESOLVEDset ip=UNRESOLVEDfor /f "tokens=2,3 delims= " %%b in ('ping -a -4 -n 1 !hostname! ^| find "Pinging"') do (set domain=%%bset ip=%%c)if errorlevel 1 (echo !hostname! !ip! [!domain!] is OFF) else (echo !hostname! !ip! [!domain!] is ON)pause
答案1
得分: 0
我有另一种方法来使用这种ping，因为我的机器是法语。例如，这个批处理脚本会对一系列`URLs`进行ping，并用不同的颜色显示它们的状态（开启/关闭）。`URLs` 在`"URLS"`变量中定义。脚本会循环遍历这些`URLs`，使用`StringFormat`函数对其进行格式化，使用`"ping"`命令获取每个URL的`IP`地址，然后利用`PSColor`函数使用颜色显示每个URL的状态（开启或关闭）。@echo offTitle Multi-Ping hosts with colorsSet URLS="non-existent-hostname","https://www.google.com","Nothingtotest","https://www.yahoo.com","www.reddit.com",^"http://www.wikipedia.com","www.stackoverflow.com","www.bing.com","NoBodyHere.com"setlocal ENABLEDELAYEDEXPANSIONfor %%a in (%URLS%) do (Call :StringFormat "%%~a"set "ip="for /f "tokens=2 delims=[]" %%b in ('ping -n 1 !URL!') do set "ip=%%b"ping -n 1 !URL!>nul && set "msg=!URL! - !ip! ON" && Call :PSColor "!msg!" Green \n || set "msg=!URL! - !ip! OFF" && Call :PSColor "!msg!" Red \n)pause & Exit::---------------------------------------------------------------------------------:StringFormat <URL>(echo Function StringReplace(Str^)echo Str = Replace(Str,"http://",""^)echo Str = Replace(Str,"https://",""^)echo StringReplace = strecho End Functionecho wscript.echo StringReplace("%~1"^))>"%tmp%\%~n0.vbs"for /f "delims=" %%a in ('Cscript /nologo "%tmp%\%~n0.vbs"') do ( set "URL=%%~a" )If Exist "%tmp%\%~n0.vbs" Del "%tmp%\%~n0.vbs"exit /b::---------------------------------------------------------------------------------:PSColor <String> <Color> <NewLine>If /I [%3] EQU [\n] (Powershell Write-Host "`0%~1" -ForegroundColor %2) Else (Powershell Write-Host "`0%~1" -ForegroundColor %2 -NoNewLine)Exit /B::---------------------------------------------------------------------------------
英文:
I have another approach using this kind of ping, because my machine is French.
For example, this batch script pings a list of URLs and displays their status (ON/OFF) with different colors.
The URLs are defined in the "URLS" variable.
The script loops through the URLs, formats them using a StringFormat function, gets the IP address of each URL using the "ping" command, and then displays the status of each URL (ON or OFF) with a color using a PSColor function.
<!-- language: lang-bat -->
@echo offTitle Multi-Ping hosts with colorsSet URLS="non-existent-hostname","https://www.google.com","Nothingtotest","https://www.yahoo.com","www.reddit.com",^"http://www.wikipedia.com","www.stackoverflow.com","www.bing.com","NoBodyHere.com"setlocal ENABLEDELAYEDEXPANSIONfor %%a in (%URLS%) do (Call :StringFormat "%%~a"set "ip="for /f "tokens=2 delims=[]" %%b in ('ping -n 1 !URL!') do set "ip=%%b"ping -n 1 !URL!>nul && set "msg=!URL! - !ip! ON" && Call :PSColor "!msg!" Green \n || set "msg=!URL! - !ip! OFF" && Call :PSColor "!msg!" Red \n)pause & Exit::---------------------------------------------------------------------------------:StringFormat <URL>(echo Function StringReplace(Str^)echo Str = Replace(Str,"http://",""^)echo Str = Replace(Str,"https://",""^)echo StringReplace = strecho End Functionecho wscript.echo StringReplace("%~1"^))>"%tmp%\%~n0.vbs"for /f "delims=" %%a in ('Cscript /nologo "%tmp%\%~n0.vbs"') do ( set "URL=%%~a" )If Exist "%tmp%\%~n0.vbs" Del "%tmp%\%~n0.vbs"exit /b::---------------------------------------------------------------------------------:PSColor <String> <Color> <NewLine>If /I [%3] EQU [\n] (Powershell Write-Host "`0%~1" -ForegroundColor %2) Else (Powershell Write-Host "`0%~1" -ForegroundColor %2 -NoNewLine)Exit /B::---------------------------------------------------------------------------------
答案2
得分: 0
我弄清楚了，谢谢大家的提示。
@echo off
setlocal ENABLEDELAYEDEXPANSION
set hostname=non-existent-hostname
set domain=UNRESOLVED
set ip=UNRESOLVED
for /f "tokens=2,3 delims= " %%b in ('ping -a -4 -n 1 !hostname! ^| find "Pinging"') do (
set domain=%%b
set ip=%%c
)
ping -n 1 %hostname% >nul
if %errorlevel% == 0 (
echo %hostname% %ip% [%domain%] is ON
) else (
echo %hostname% %ip% [%domain%] is OFF
)
pause
英文:
I figured it out, thanks everyone for hints.
@echo offsetlocal ENABLEDELAYEDEXPANSIONset hostname=non-existent-hostnameset domain=UNRESOLVEDset ip=UNRESOLVEDfor /f "tokens=2,3 delims= " %%b in ('ping -a -4 -n 1 !hostname! ^| find "Pinging"') do (set domain=%%bset ip=%%c)ping -n 1 %hostname% >nulif %errorlevel% == 0 (echo %hostname% %ip% [%domain%] is ON) else (echo %hostname% %ip% [%domain%] is OFF)pause
通过集体智慧和协作来改善编程学习和解决问题的方式。致力于成为全球开发者共同参与的知识库，让每个人都能够通过互相帮助和分享经验来进步。
评论