修改值/结构的最佳实践方法

huangapple
go评论144阅读模式
英文:

Best practice to modify value/struct

问题

我发现修改值/结构的方法有两种（可能还有其他方法）。

  1. 通过引用传递值
  2. 从函数/方法获取值，处理错误，然后赋值

我知道这两种方法都可以工作，但我想知道在Go语言世界中哪种方法是最佳实践。

我在这里给出了两个示例。

abc.go

  1. package main
  3. import (
  4. 	"fmt"
  5. 	"github.com/pkg/errors"
  6. )
  8. type Request struct {
  9. 	AdType string
  10. }
  12. type Response struct {
  13. 	Message string
  14. }
  16. func main() {
  17. 	// 实现方法1
  18. 	// 通过处理函数来修改响应
  19. 	res1 := Response{}
  20. 	req1 := Request{AdType: "banner"}
  21. 	req1.handleResponse(&res1)
  23. 	// 实现方法2
  24. 	res2 := Response{}
  25. 	req2 := Request{AdType: "image"}
  26. 	if r, e := req2.getRequestMessage(); e == nil {
  27. 		res2.Message = r
  28. 	}
  29. 	fmt.Println(res1)
  30. 	fmt.Println(res2)
  31. }
  33. func (req *Request) handleResponse(res *Response) {
  34. 	if req.AdType == "banner" {
  35. 		res.Message = "Banner Ad"
  36. 	} else if req.AdType == "video" {
  37. 		res.Message = "Video Ad"
  38. 	}
  39. }
  41. func (req *Request) getRequestMessage() (string, error) {
  42. 	if req.AdType == "banner" {
  43. 		return "Banner Ad", nil
  44. 	} else if req.AdType == "video" {
  45. 		return "Video Ad", nil
  46. 	}
  47. 	return "", errors.New("Invalid ad type")
  48. }
英文:

I found that to modify a value/struct I can do it in two ways(maybe others exist).

  1. Pass value by reference
  2. Get value from function/method, handle error then assign

I know both methods work but I am wondering which method is best practice in the golang world.

I am giving both examples here.

abc.go

  1. package main
  3. import (
  4. 	"fmt"
  5. 	"github.com/pkg/errors"
  6. )
  8. type Request struct {
  9. 	AdType string
  10. }
  12. type Response struct {
  13. 	Message string
  14. }
  16. func main() {
  17. 	// Implementation 1
  18. 	// Handle response by handle and alter response
  19. 	res1 := Response{}
  20. 	req1 := Request{AdType: "banner"}
  21. 	req1.handleResponse(&res1)
  23. 	// Implementation 2
  24. 	res2 := Response{}
  25. 	req2 := Request{AdType: "image"}
  26. 	if r, e := req2.getRequestMessage(); e == nil {
  27. 		res2.Message = r
  28. 	}
  29. 	fmt.Println(res1)
  30. 	fmt.Println(res2)
  31. }
  33. func (req *Request) handleResponse(res *Response) {
  34. 	if req.AdType == "banner" {
  35. 		res.Message = "Banner Ad"
  36. 	} else if req.AdType == "video"{
  37. 		res.Message = "Video Ad"
  38. 	}
  39. }
  41. func (req *Request) getRequestMessage() (string, error) {
  42. 	if req.AdType == "banner" {
  43. 		return "Banner Ad", nil
  44. 	} else if req.AdType == "video"{
  45. 		return "Video Ad", nil
  46. 	}
  47. 	return "", errors.New("Invalid ad type")
  48. }

答案1

得分: 1

老实说，我认为像这样的代码更符合Go的标准。它更清晰、更易于理解。

  1. package main
  3. import (
  4. 	"errors"
  5. 	"fmt"
  6. )
  8. type Request struct {
  9. 	AdType string
  10. }
  12. type Response struct {
  13. 	Message string
  14. }
  16. func main() {
  17. 	res, err := handleRequest(&Request{AdType: "banner"})
  18. 	if err != nil {
  19. 		fmt.Println("获取响应时出错")
  20. 	}
  21. 	fmt.Println(res)
  22. }
  24. func handleRequest(request *Request) (*Response, error) {
  25. 	res := new(Response)
  26. 	switch request.AdType {
  27. 	case "banner":
  28. 		res.Message = "横幅广告"
  29. 		return res, nil
  30. 	case "video":
  31. 		res.Message = "视频广告"
  32. 		return res, nil
  33. 	}
  34. 	return nil, errors.New("无效的广告类型")
  35. }
英文:

Honestly, I think something like this is more of the standard in go. It's a lot cleaner and easier to follow.

  1. package main
  3. import (
  4. 	"errors"
  5. 	"fmt"
  6. )
  8. type Request struct {
  9. 	AdType string
  10. }
  12. type Response struct {
  13. 	Message string
  14. }
  16. func main() {
  17. 	res, err := handleRequest(&Request{AdType: "banner"})
  18. 	if err != nil {
  19. 		fmt.Println("error getting response")
  20. 	}
  21. 	fmt.Println(res)
  22. }
  24. func handleRequest(request *Request) (*Response, error) {
  25. 	res := new(Response)
  26.     switch request.AdType {
  27. 	case "banner":
  28. 		res.Message = "Banner Ad"
  29. 		return res, nil
  30. 	case "video":
  31. 		res.Message = "Video Ad"
  32. 		return res, nil
  33. 	}
  34.     return nil, errors.New("invalid ad type")
  35. }

huangapple
  • 本文由 发表于 2021年11月18日 15:33:49
  • 转载请务必保留本文链接：https://go.coder-hub.com/70016027.html
  • go
匿名

发表评论

匿名网友

:?: :razz: :sad: :evil: :!: :smile: :oops: :grin: :eek: :shock: :???: :cool: :lol: :mad: :twisted: :roll: :wink: :idea: :arrow: :neutral: :cry: :mrgreen:

确定