@RequestMapping 映射不正确。

huangapple
go评论105阅读模式
英文:

@RequestMapping doesn't map correctly

问题

问题是当我在CommentController类上方使用我的注释@RequestMapping("/adverts/{id}")时，我可以通过两种方式访问该类，即：localhost:8080/adverts/1/comments和localhost:8080/comments。我如何禁止访问localhost:8080/comments？谢谢。

英文:

My problem is that when I use my annotation @RequestMapping("/adverts/{id}") above my CommentController class, I can reach this class using both (i.e): localhost:8080/adverts/1/comments and localhost:8080/comments. How I can disable reaching localhost:8080/comments? Thank you.

  1. @RestController
  2. class CommentController {
  4.     private final CommentRepository commentRepository;
  5.     private final AdvertRepository advertRepository;
  6.     private final CommentModelAssembler assembler;
  8.     CommentController(CommentRepository commentRepository, AdvertRepository advertRepository, CommentModelAssembler assembler) {
  9.         this.commentRepository = commentRepository;
  10.         this.advertRepository = advertRepository;
  11.         this.assembler = assembler;
  12.     }
  14.     @GetMapping("/adverts/{advertId}/comments")
  15.     CollectionModel<EntityModel<Comment>> all() {
  16.         List<EntityModel<Comment>> comments =
  17.                 commentRepository.findAll().stream()
  18.                         .map(assembler::toModel)
  19.                         .collect(Collectors.toList());
  20.         return CollectionModel.of(comments,
  21.                 linkTo(methodOn(CommentController.class).all()).withSelfRel());
  22.     }
  24.     @PostMapping("/adverts/{advertId}/comments")
  25.     Comment newComment(@RequestBody Comment newComment) {
  26.         return commentRepository.save(newComment);
  27.     }
  29.     @GetMapping("/adverts/{advertId}/comments/{id}")
  30.     EntityModel<Comment> one(@PathVariable Long id) {
  31.         Comment comment = commentRepository.findById(id)
  32.                 .orElseThrow(() -> new CommentNotFoundException(id));
  33.         return assembler.toModel(comment);
  34.     }
  36.     @PutMapping("/adverts/{advertId}//comments/{id}")
  37.     Comment replaceComment(@RequestBody Comment newComment,
  38.                           @PathVariable Long id) {
  39.         return commentRepository.findById(id)
  40.                 .map(comment -> {
  41.                     comment.setAdvertId(newComment.getAdvertId());
  42.                     comment.setComment(newComment.getComment());
  43.                     return commentRepository.save(comment);
  44.                 })
  45.                 .orElseGet(() -> {
  46.                     newComment.setId(id);
  47.                     return commentRepository.save(newComment);
  48.                 });
  49.     }
  51.     @DeleteMapping("/adverts/{advertId}/comments/{id}")
  52.     void deleteComment(@PathVariable Long id) {
  53.         commentRepository.deleteById(id);
  54.     }
  55. }
  1. @Component
  2. public class CommentModelAssembler implements RepresentationModelAssembler<Comment, EntityModel<Comment>> {
  4.     @Override
  5.     public EntityModel<Comment> toModel(Comment comment) {
  6.         return EntityModel.of(comment,
  7.                 linkTo(methodOn(CommentController.class).one(comment.getId())).withSelfRel(),
  8.                 linkTo(methodOn(CommentController.class).all()).withRel("comments"));
  9.     }
  10. }
  1. @RestController
  2. class UserController {
  4.     private final UserRepository repository;
  5.     private final UserModelAssembler assembler;
  7.     UserController(UserRepository repository, UserModelAssembler assembler) {
  8.         this.repository = repository;
  9.         this.assembler = assembler;
  10.     }
  12.     @GetMapping("/users")
  13.     CollectionModel<EntityModel<User>> all() {
  14.         List<EntityModel<User>> users =
  15.                 repository.findAll().stream()
  16.                         .map(assembler::toModel)
  17.                         .collect(Collectors.toList());
  18.         return CollectionModel.of(users,
  19.                 linkTo(methodOn(UserController.class).all()).withSelfRel());
  20.     }
  22.     @PostMapping("/users")
  23.     User newUser(@RequestBody User newUser) {
  24.         return repository.save(newUser);
  25.     }
  27.     @GetMapping("/users/{id}")
  28.     EntityModel<User> one(@PathVariable Long id) {
  29.         User user = repository.findById(id)
  30.                 .orElseThrow(() -> new UserNotFoundException(id));
  31.         return assembler.toModel(user);
  32.     }
  34.     @PutMapping("/users/{id}")
  35.     User replaceUser(@RequestBody User newUser,
  36.                      @PathVariable Long id) {
  37.         return repository.findById(id)
  38.                 .map(user -> {
  39.                     user.setName(newUser.getName());
  40.                     user.setRole(newUser.getRole());
  41.                     user.setBoughtVehicles(newUser.getBoughtVehicles());
  42.                     user.setSoldVehicles(newUser.getSoldVehicles());
  43.                     return repository.save(user);
  44.                 })
  45.                 .orElseGet(() -> {
  46.                     newUser.setId(id);
  47.                     return repository.save(newUser);
  48.                 });
  49.     }
  51.     @DeleteMapping("/users/{id}")
  52.     void deleteUser(@PathVariable Long id) {
  53.         repository.deleteById(id);
  54.     }
  55. }
  1. @RestController
  2. class AdvertController {
  4.     private final AdvertRepository repository;
  5.     private final AdvertsModelAssembler assembler;
  7.     AdvertController(AdvertRepository repository, AdvertsModelAssembler assembler) {
  8.         this.repository = repository;
  9.         this.assembler = assembler;
  10.     }
  12.     @GetMapping("/adverts")
  13.     CollectionModel<EntityModel<Advert>> all() {
  14.         List<EntityModel<Advert>> adverts =
  15.                 repository.findAll().stream()
  16.                 .map(assembler::toModel)
  17.                 .collect(Collectors.toList());
  18.         return CollectionModel.of(adverts,
  19.                 linkTo(methodOn(AdvertController.class).all()).withSelfRel());
  20.     }
  22.     @PostMapping("/adverts")
  23.     Advert newAdvert(@RequestBody Advert newAdvert) {
  24.         return repository.save(newAdvert);
  25.     }
  27.     @GetMapping("/adverts/{id}")
  28.     EntityModel<Advert> one(@PathVariable Long id) {
  29.         Advert advert = repository.findById(id)
  30.                 .orElseThrow(() -> new AdvertNotFoundException(id));
  31.         return assembler.toModel(advert);
  32.     }
  34.     @PutMapping("/adverts/{id}")
  35.     Advert replaceAdvert(@RequestBody Advert newAdvert,
  36.                          @PathVariable Long id) {
  37.         return repository.findById(id)
  38.                 .map(advert -> {
  39.                     advert.setAutoCategory(newAdvert.getAutoCategory());
  40.                     advert.setAutoName(newAdvert.getAutoName());
  41.                     advert.setAutoModel(newAdvert.getAutoModel());
  42.                     advert.setComments(newAdvert.getComments());
  43.                     return repository.save(advert);
  44.                 })
  45.                 .orElseGet(() -> {
  46.                     newAdvert.setId(id);
  47.                     return repository.save(newAdvert);
  48.                 });
  49.     }
  51.     @DeleteMapping("/adverts/{id}")
  52.     void deleteAdvert(@PathVariable Long id) {
  53.         repository.deleteById(id);
  54.     }
  55. }

localhost:8080/comments result:

  1. {
  2.   "_embedded" : {
  3.     "comments" : [ {
  4.       "advertId" : 1,
  5.       "comment" : "That's a nice car!",
  6.       "_links" : {
  7.         "self" : {
  8.           "href" : "http://localhost:8080/comments/3"
  9.         },
  10.         "comment" : {
  11.           "href" : "http://localhost:8080/comments/3"
  12.         }
  13.       }
  14.     }, {
  15.       "advertId" : 2,
  16.       "comment" : "What a nice color of the car!",
  17.       "_links" : {
  18.         "self" : {
  19.           "href" : "http://localhost:8080/comments/4"
  20.         },
  21.         "comment" : {
  22.           "href" : "http://localhost:8080/comments/4"
  23.         }
  24.       }
  25.     } ]
  26.   },
  27.   "_links" : {
  28.     "self" : {
  29.       "href" : "http://localhost:8080/comments"
  30.     },
  31.     "profile" : {
  32.       "href" : "http://localhost:8080/profile/comments"
  33.     }
  34.   },
  35.   "page" : {
  36.     "size" : 20,
  37.     "totalElements" : 2,
  38.     "totalPages" : 1,
  39.     "number" : 0
  40.   }
  41. }

答案1

得分: 1

你的 localhost:8080/comments API 似乎来自不同的控制器，而不是你所发布的控制器。

更新：
如果你只想看到每个用户的评论，你可以按照以下方式更改你的控制器定义，使其更通用和简单：

  1. @RestController
  2. @RequestMapping("/adverts")
  3. class CommentController {

更新 2：
你需要更新你的控制器 URL 映射。通常，我们为特定的控制器/目的定义一个公共的 URL 名称。比如你的 CommonController，你可以这样做：

  1. @RestController
  2. @RequestMapping("/common")
  3. class CommentController {

注意这个名字 /common。然后，在这个控制器下，你可以添加其他的 API，比如 /comments/all、/comments/{id}、/comments/others。要访问这些控制器方法，你必须按照这个层次结构，比如：
/common/comments/all 或者 /common/comments/1

类似地，对于 AdvertController：

  1. @RestController
  2. @RequestMapping("/advert")
  3. class AdvertController {

同样，检查一下常见的 URL 名称 /advert。在这个控制器下的 API 将会有这样的命名：
/all、/{id}。要访问这个控制器方法，使用的 URL 形式如下：
/advert/all、/advert/1

这应该能够清楚地解释你的问题。
需要注意的是，我在示例 URL 中排除了基本的 localhost:8080 部分，请记得添加上这部分。
希望这能够达到你的目的。

英文:

Your localhost:8080/comments API seems to come from different controller, not from this one you have posted.

Update:
If you want to see only each user's comment, you can change your controller definition following way to make it more generic and simple:

  1. @RestController
  2. @RequestMapping("/adverts")
  3. class CommentController {

Update 2:
You need to update your controller-url mapping. Generally, we define a common url-name for a specific controller/purpose. Like for your CommonController you can do this:

  1. @RestController
  2.     @RequestMapping("/common")
  3.     class CommentController {

See the name /commom. Then, under this controller, you add other API like /comments/all, /comments/{id}, /comments/others. To access these controller method, you must follow this hierarchy like:
/common/comments/all or /common/comments/1
Similarly for AdvertController:

  1. @RestController
  2. @RequestMapping("/advert")
  3. class AdvertController {

Again, check the common url-name /advert. API under this controller will have naming like this:
/all, '/{id}'. To access this controller method use URL this way:
/advert/all, /advert/1
This should clear your idea.
One thing, I have excluded the base-url localhost:8080 part from the url-example I have shown, mind adding this.
Hope, this will server your purpose.

huangapple
  • 本文由 发表于 2020年9月23日 13:57:06
  • 转载请务必保留本文链接：https://go.coder-hub.com/64021854.html
  • java
  • request-mapping
  • spring-boot
匿名

发表评论

匿名网友

:?: :razz: :sad: :evil: :!: :smile: :oops: :grin: :eek: :shock: :???: :cool: :lol: :mad: :twisted: :roll: :wink: :idea: :arrow: :neutral: :cry: :mrgreen:

确定