我在处理一个基于测试创建矩形的类时遇到问题。

huangapple
go评论124阅读模式
英文:

I have problem with class that creates rectangle based on a test

问题

好的，以下是您提供的代码的中文翻译：

  1. // 测试矩形的方法，基于给定的点、高度和宽度创建矩形
  2. public void testRectangle1() {
  3.     Point center = new Point(20, 30);
  4.     Rectangle rect = new Rectangle(center, 20, 20);
  5.     assertAll(
  6.         () -> assertEquals(10, rect.getTopLeft().getX()),
  7.         () -> assertEquals(20, rect.getTopLeft().getY()),
  8.         () -> assertEquals(30, rect.getBottomRight().getX()),
  9.         () -> assertEquals(40, rect.getBottomRight().getY()),
  10.         () -> assertEquals(20, rect.getWidth()),
  11.         () -> assertEquals(20, rect.getHeight())
  12.     );
  13. }
  15. // Point 类定义
  16. package net.thumbtack.school.figures.v1;
  18. public class Point {
  20.     private int x, y;
  22.     public Point(int x, int y) {
  23.         this.x = x;
  24.         this.y = y;
  25.     }
  27.     public Point() {
  28.         this(0, 0);
  29.     }
  31.     public int getX() {
  32.         return x;
  33.     }
  35.     public void setX(int x) {
  36.         this.x = x;
  37.     }
  39.     public int getY() {
  40.         return y;
  41.     }
  43.     public void setY(int y) {
  44.         this.y = y;
  45.     }
  47.     public void moveTo(int newX, int newY) {
  48.         x = newX;
  49.         y = newY;
  50.     }
  52.     public void moveRel(int dx, int dy) {
  53.         x += dx;
  54.         y += dy;
  55.     }
  57.     @Override
  58.     public int hashCode() {
  59.         final int prime = 31;
  60.         int result = 1;
  61.         result = prime * result + x;
  62.         result = prime * result + y;
  63.         return result;
  64.     }
  66.     @Override
  67.     public boolean equals(Object obj) {
  68.         if (this == obj)
  69.             return true;
  70.         if (obj == null)
  71.             return false;
  72.         if (getClass() != obj.getClass())
  73.             return false;
  74.         Point other = (Point) obj;
  75.         if (x != other.x)
  76.             return false;
  77.         if (y != other.y)
  78.             return false;
  79.         return true;
  80.     }
  81. }
  83. // 创建矩形的类定义
  84. package net.thumbtack.school.figures.v1;
  86. public class Rectangle {
  87.     public int width;
  88.     public int height;
  89.     public Point center;
  90.     public int xCenter;
  91.     public int yCenter;
  92.     private Point point;
  94.     // 矩形构造方法
  95.     public Rectangle(Point center, int width, int height) {
  96.         this.width = width;
  97.         this.height = height;
  98.         this.center = center;
  99.     }
  101.     // 获取矩形左上角的点
  102.     public Point getTopLeft() {
  103.         Point point = getCenter();
  104.         point.moveRel(- width / 2, - height / 2);
  105.         return point;
  106.     }
  108.     // 获取矩形右下角的点
  109.     public Point getBottomRight() {
  110.         Point point = getCenter();
  111.         point.moveRel(width / 2,  height / 2);
  112.         return point;
  113.     }
  115.     // 获取矩形宽度
  116.     public int getWidth() {
  117.         return width;
  118.     }
  120.     // 获取矩形高度
  121.     public int getHeight() {
  122.         return height;
  123.     }
  125.     // 获取矩形中心点
  126.     public Point getCenter() {
  127.        Point center = new Point(xCenter, yCenter);
  128.        return center;
  129.     }
  130. }

关于您提到的问题，您的构造函数 public Rectangle(Point center, int width, int height) 中似乎存在问题，导致测试返回错误的值。您可能需要仔细检查该构造函数内部的逻辑，确保正确计算矩形的位置和属性。

英文:

Ok so i have rectangle that should be created based on: method point that will crete coordinates of it center and values of hight and width, all value are based on this test

  1. public void testRectangle1() {
  2. Point center = new Point(20, 30);
  3. Rectangle rect = new Rectangle(center, 20, 20);
  4. assertAll(
  5. () -> assertEquals(10, rect.getTopLeft().getX()),
  6. () -> assertEquals(20, rect.getTopLeft().getY()),
  7. () -> assertEquals(30, rect.getBottomRight().getX()),
  8. () -> assertEquals(40, rect.getBottomRight().getY()),
  9. () -> assertEquals(20, rect.getWidth()),
  10. () -> assertEquals(20, rect.getHeight())
  11. );
  12. }

I have prewritten class point that i will add here for overall clarity

  1. package net.thumbtack.school.figures.v1;
  2. public class Point {
  3. private int x, y;
  4. public Point(int x, int y) {
  5. this.x = x;
  6. this.y = y;
  7. }
  8. public Point() {
  9. this(0, 0);
  10. }
  11. public int getX() {
  12. return x;
  13. }
  14. public void setX(int x) {
  15. this.x = x;
  16. }
  17. public int getY() {
  18. return y;
  19. }
  20. public void setY(int y) {
  21. this.y = y;
  22. }
  23. public void moveTo(int newX, int newY) {
  24. x = newX;
  25. y = newY;
  26. }
  27. public void moveRel(int dx, int dy) {
  28. x += dx;
  29. y += dy;
  30. }
  31. @Override
  32. public int hashCode() {
  33. final int prime = 31;
  34. int result = 1;
  35. result = prime * result + x;
  36. result = prime * result + y;
  37. return result;
  38. }
  39. @Override
  40. public boolean equals(Object obj) {
  41. if (this == obj)
  42. return true;
  43. if (obj == null)
  44. return false;
  45. if (getClass() != obj.getClass())
  46. return false;
  47. Point other = (Point) obj;
  48. if (x != other.x)
  49. return false;
  50. if (y != other.y)
  51. return false;
  52. return true;
  53. }
  54. }

And this is class for creating rectangle

  1. package net.thumbtack.school.figures.v1;
  2. public class Rectangle {
  3. public int width;
  4. public int height;
  5. public Point center;
  6. public int xCenter;
  7. public int yCenter;
  8. private Point point;
  9. public Rectangle(Point center, int width, int height) {
  10. this.width=width;
  11. this.height=height;
  12. this.center=center;
  13. }
  14. public Point getTopLeft() {
  15. Point point = getCenter();
  16. point.moveRel(- width / 2, - height / 2);
  17. return point;
  18. }
  19. public Point getBottomRight() {
  20. Point point = getCenter();
  21. point.moveRel(width / 2,  height / 2);
  22. return point;
  23. }
  24. public int getWidth() {
  25. return width;
  26. }
  27. public int getHeight() {
  28. return height;
  29. }
  30. public Point getCenter() {
  31. Point center = new Point(xCenter, yCenter);
  32. return center;
  33. }

So problem is in constructor public Rectangle(Point center, int width, int height) when i run the test it returns wirng values

expected: <10> but was: <-10>
Comparison Failure:
Expected :10
Actual :-10

expected: <20> but was: <-10>
Comparison Failure:
Expected :20
Actual :-10

expected: <30> but was: <10>
Comparison Failure:
Expected :30
Actual :10

expected: <40> but was: <10>
Comparison Failure:
Expected :40
Actual :10

I dont this that the problem is into other methods becouse when i use them in different but simmilar constrictors everything works.

答案1

得分: 0

如maloomeister所提到的，您必须在使用之前初始化xCenter或yCenter，否则xCenter和yCenter的值将为0。

修改getCenter()方法：

  1. public Point getCenter() {
  2. Point point = new Point(center.getX(), center.getY());
  3. return point;
  4. }
英文:

As maloomeister mentioned you must init xCenter or yCenter before used，or the value of xCenter and yCenter is 0.

modify getCenter() method:

  1. public Point getCenter() {
  2. Point point = new Point(center.getX(), center.getY());
  3. return point;
  4. }

huangapple
  • 本文由 发表于 2020年9月21日 13:15:37
  • 转载请务必保留本文链接：https://go.coder-hub.com/63986533.html
  • constructor
  • java
  • rectangles
匿名

发表评论

匿名网友

:?: :razz: :sad: :evil: :!: :smile: :oops: :grin: :eek: :shock: :???: :cool: :lol: :mad: :twisted: :roll: :wink: :idea: :arrow: :neutral: :cry: :mrgreen:

确定