将Java转换为Kotlin会破坏上下文菜单。

huangapple go评论79阅读模式
英文:

Convert java to kotlin breaks contextmenu

问题

我已经将您提供的内容翻译成中文,如下:

我一直在将一个项目转换为 Kotlin,并发现了一个问题。来自 Java 代码的上下文菜单在生成的 Kotlin 代码中出现问题。这是一个项目源代码的简化测试。它仅包含一个主活动(main activity),一个单一的布局和一个上下文菜单。Java 版本可用,但是 Kotlin 版本会崩溃。我唯一能想到的不寻常之处是我注册的视图是 RelativeLayout 中的一个 imageView。

Java 版本中的 MainActivity.java 代码如下:

public class MainActivity extends AppCompatActivity {
    private static int animationSpeed = 0;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        registerForContextMenu(findViewById(R.id.imageView));
    }

    @Override
    public void onCreateContextMenu(ContextMenu menu, View v, ContextMenu.ContextMenuInfo menuInfo) {
        super.onCreateContextMenu(menu, v, menuInfo);
        MenuInflater inflater = getMenuInflater();
        inflater.inflate(R.menu.speed_select, menu);
        menu.getItem(animationSpeed).setChecked(true);
    }

    @Override
    public boolean onContextItemSelected(MenuItem item) {
        int itemId = item.getItemId();
        boolean rv = true;
        switch (itemId) {
            case R.id.animate_slow:
                animationSpeed = 0;
                break;
            case R.id.animate_normal:
                animationSpeed = 1;
                break;
            case R.id.animate_fast:
                animationSpeed = 2;
                break;
            default:
                Log.d("onContextItemSelected", String.format("menu item unhandled:0x%08x", itemId));
                rv = false;
        }
        return rv;
    }
}

Kotlin 版本中的 MainActivity.kt 代码如下:

class MainActivity : AppCompatActivity() {
    companion object {
        private var animationSpeed = 0
    }

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContentView(R.layout.activity_main)
        registerForContextMenu(findViewById(R.id.imageView))
    }

    override fun onCreateContextMenu(menu: ContextMenu, v: View, menuInfo: ContextMenuInfo) {
        super.onCreateContextMenu(menu, v, menuInfo)
        val inflater = menuInflater
        inflater.inflate(R.menu.speed_select, menu)
        menu.getItem(animationSpeed)?.isChecked = true
    }

    override fun onContextItemSelected(item: MenuItem): Boolean {
        val itemId = item.itemId
        var rv = true
        when (itemId) {
            R.id.animate_slow -> animationSpeed = 0
            R.id.animate_normal -> animationSpeed = 1
            R.id.animate_fast -> animationSpeed = 2
            else -> {
                Log.d("onContextItemSelected", String.format("menu item unhandled:0x%08x", itemId))
                rv = false
            }
        }
        return rv
    }
}

另外,您提供的菜单文件 speed_select.xml 和活动布局文件也保持不变。

英文:

I've been converting a project to Kotlin and discovered a problem. The context menu from the java code is broken in the generated kotlin.<br/>This is a simplified test of the source from the project. It consists of only a main activity with a single layout and a context menu. The java version works but the kotlin version crashes. The only thing I can think of that is unusual is that the view I'm registering is an imageView in a RelativeLayout.

 java.lang.NullPointerException:
Parameter specified as non-null is null: 
method kotlin.jvm.internal.Intrinsics.checkNotNullParameter
, parameter menuInfo
at com...MainActivity.onCreateContextMenu(MainActivity.kt)
at android.view.View.createContextMenu(View.java:8392)
at com.android.internal.view.menu.ContextMenuBuilder
.show(ContextMenuBuilder.java:81)
at com.android.internal.policy.impl
.PhoneWindow$DecorView
.showContextMenuForChild(PhoneWindow.java:2517)
at android.view.ViewGroup.showContextMenuForChild(ViewGroup.java:658)

MainActivity.java is:

public class MainActivity extends AppCompatActivity {
private static int animationSpeed = 0;
@Override
protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState);
setContentView(R.layout.activity_main);
registerForContextMenu(findViewById(R.id.imageView));
}
@Override
public void onCreateContextMenu(ContextMenu menu, View v,
ContextMenu.ContextMenuInfo menuInfo) {
super.onCreateContextMenu(menu, v, menuInfo);
MenuInflater inflater = getMenuInflater();
inflater.inflate(R.menu.speed_select, menu);
menu.getItem(animationSpeed).setChecked(true);
}
@Override
public boolean onContextItemSelected(MenuItem item) {
int itemId = item.getItemId();
boolean rv = true;
switch(itemId) {
case R.id.animate_slow: animationSpeed = 0; break;
case R.id.animate_normal: animationSpeed = 1; break;
case R.id.animate_fast: animationSpeed = 2; break;
default: Log.d(&quot;onContextItemSelected&quot;, String.format(
&quot;menu item unhandled:0x%08x&quot;, itemId)
);
rv = false;
}
return rv;
}
}

MainActivity.kt is:

class MainActivity : AppCompatActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContentView(R.layout.activity_main)
registerForContextMenu(findViewById(R.id.imageView))
}
override fun onCreateContextMenu(menu: ContextMenu, v: View,
menuInfo: ContextMenuInfo) {
super.onCreateContextMenu(menu, v, menuInfo)
val inflater = menuInflater
inflater.inflate(R.menu.speed_select, menu)
menu.getItem(animationSpeed).isChecked = true
}
override fun onContextItemSelected(item: MenuItem): Boolean {
val itemId = item.itemId
var rv = true
when (itemId) {
R.id.animate_slow -&gt; animationSpeed = 0
R.id.animate_normal -&gt; animationSpeed = 1
R.id.animate_fast -&gt; animationSpeed = 2
else -&gt; {
Log.d(&quot;onContextItemSelected&quot;, String.format(
&quot;menu item unhandled:0x%08x&quot;, itemId))
rv = false
}
}
return rv
}
companion object {
private var animationSpeed = 0
}
}

My menu file is:

&lt;?xml version=&quot;1.0&quot; encoding=&quot;utf-8&quot;?&gt;
&lt;menu xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot; &gt;
&lt;group 
android:checkableBehavior=&quot;single&quot;
android:id=&quot;@+id/animate_speed&quot; &gt;
&lt;item android:id=&quot;@+id/animate_slow&quot;
android:title=&quot;@string/slow&quot; /&gt;
&lt;item android:id=&quot;@+id/animate_normal&quot;
android:title=&quot;@string/normal&quot; /&gt;
&lt;item android:id=&quot;@+id/animate_fast&quot;
android:title=&quot;@string/fast&quot; /&gt;
&lt;/group&gt;
&lt;/menu&gt;

The activity layout is:

&lt;?xml version=&quot;1.0&quot; encoding=&quot;utf-8&quot;?&gt;
&lt;RelativeLayout
xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;
android:id=&quot;@+id/relative_layout&quot;
android:layout_width=&quot;match_parent&quot;
android:layout_height=&quot;match_parent&quot;&gt;
&lt;ImageView
android:id=&quot;@+id/imageView&quot;
android:layout_width=&quot;250dp&quot;
android:layout_height=&quot;250dp&quot;
android:layout_centerInParent=&quot;true&quot;
android:background=&quot;@drawable/andy&quot;
/&gt;
&lt;/RelativeLayout&gt;

I've tried breaking in the onCreateContextMenu but never get there.<br/>
I'm using Kotlin 1.40, AndroidStudio 4.01, SDK 30, and gradle 4.01. I've been looking at the docs and the code for a couple of days now and to me, the generated kotlin looks right.<br/>Thanks!

Thanks to John Healy below this was solved.
John said he thought it might be in Kotlin's null-safety handling. I doubted so I added a log statement to the working Java code and menuInfo was coming in as a null. I added a @Nullable annotation to the Java declaration which gave me:

public void onCreateContextMenu(
ContextMenu menu, View v,
@Nullable ContextMenu.ContextMenuInfo menuInfo)

Testing of the Java code showed the compiler and lint were happy and the code still ran. I again ran the jave through the conversion process and the resulting kotlin signature for the function is:

override fun onCreateContextMenu(
menu: ContextMenu, v: View,
menuInfo: ContextMenuInfo?)

I tested the Kotlin and it now works too!

NOTE: for your edification and amusement I posted the source on
git hub.

答案1

得分: 3

我只是在发布这个回复到我的问题,以便人们注意到问题得到了解决,这要归功于一位评论者。这个修复方法只适用于使用菜单列表而不是创建单独菜单项的情况,并且只有在使用Kotlin时才需要进行修复,因为Kotlin处理空安全的方式不同。请查看问题末尾以及我对那个问题的评论,
Steve S。

英文:

I'm only puting up this reply to my question so people will notice a solution was found thanks to a commentor. This fix only applies if you are using a menu list rather than creating individual menu items and the fix is only necessary for Kotlin because of the way in which Kotlin handles null-safety. Please look at the end of the question and at my comment to that question,
<br>Steve S.

huangapple
  • 本文由 发表于 2020年9月2日 06:19:08
  • 转载请务必保留本文链接:https://go.coder-hub.com/63696170.html
匿名

发表评论

匿名网友

:?: :razz: :sad: :evil: :!: :smile: :oops: :grin: :eek: :shock: :???: :cool: :lol: :mad: :twisted: :roll: :wink: :idea: :arrow: :neutral: :cry: :mrgreen:

确定