Android: Unable to call back buttonOnCklick

Actually I don't understand why it doesn't see the buttonOnClick listener?

public class GeneralActivity extends AppCompatActivity {
    // with or without these lines below 
    private View.OnClickListener buttonOnClick = this.buttonOnClick;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        GlobalData.getInstance().gContext = this;
        setContentView(R.layout.activity_general);
        ((TextView) findViewById(R.id.licence)).setText(MySettings.Values().LicenceNo);
        Button connect = (Button)findViewById(R.id.connect);
        connect.setOnClickListener(buttonOnClick);
        Button send = (Button)findViewById(R.id.sendall);
        send.setOnClickListener(buttonOnClick);
    }

    boolean clicked = false;
    public static String LICENCE = "";

    public void buttonOnClick(View v) {
        MessageBox.Show("Connect me");
        Button b = (Button) v;
        if (b.getId() == R.id.connect) {
            MessageBox.Show("Connect me");
                return;

Also,
In GeneralActivitry designer everything is written out - onClick for both buttons and this method referred to the GeneralActivity.

Pls, see the movie and tell me what's wrong now?
youtube.com/watch?v=heD9QGKtusY&feature=youtu.be

FULL CODE OF GENERALACTIVITY LAYOUT:

<?xml version="1.0" encoding="utf-8"?>
    <LinearLayout
        android:layout_width="fill_parent"
        android:layout_height="fill_parent"
        android:orientation="vertical"
        xmlns:android="http://schemas.android.com/apk/res/android">

            <EditText
                android:id="@+id/licence"
                android:layout_width="match_parent"
                android:layout_height="30pt"
                android:ems="10"
                android:hint="1SAT"
                android:inputType="textPersonName"
                android:layout_weight="0"
                android:singleLine="true"
                android:text="SATEST LICENCE NUMBER" />

    <Button
        android:id="@+id/connect"
        android:layout_width="match_parent"
        android:layout_height="30pt"
        android:layout_weight="0"
        android:onClick="buttonOnClick"
        android:text="CONNECT" />

    <LinearLayout
        android:id="@+id/messages"
        android:layout_width="match_parent"
        android:layout_height="fill_parent"
        android:layout_weight="1"
        android:orientation="vertical" />

    <Button
        android:id="@+id/sendall"
        android:layout_width="match_parent"
        android:layout_height="30pt"
        android:layout_weight="0"
        android:enabled="false"
        android:onClick="buttonOnClick"
        android:text="SEND2ALL" />

    </LinearLayout>

=====================================
Well, I don't like this site exactly because of that kind of people who set -1 without any reason for that.. they just like shitters in that pages.
I explained my problem with MAXIMUM example and even VIDEO.. WHAT ELSE do you need to see to get the question clear? Idiots.

Ok, let they live, it is the shit policy of this site holders..

Now you read carefully what was my error:

When I implemented OnViewListener interface I forgot to mark the method onClick with @Override and another "BIG" mistake was that the handler name onClick I wrote from UPPER LETTER OnClick..

Actually that was my main mistake. Before publishing my Q here, I try to understand everything by myself, and I tried all of the suggestions that guys gave me.. but the

> letter O and o

• hmm you understood )))

I am 30 years in software developing, and these kind of mistakes are the hardest mistakes I have ever met. Same like brackets [ { jr (..

Thank you all for you help.. I'll set the Answer to the first one.. Thank you again.

Option - 1: You have already set the onClick listener to button from xml, so no need to set it again from java code. Remove those line.

public class GeneralActivity extends AppCompatActivity {
    // with or without these lines below 
    //private View.OnClickListener buttonOnClick = this.buttonOnClick;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        
        ....

        //Button connect = (Button) findViewById(R.id.connect);
        //connect.setOnClickListener(buttonOnClick);
        //Button send = (Button) findViewById(R.id.sendall);
        //send.setOnClickListener(buttonOnClick);
    }

    public void buttonOnClick(View v) {
        MessageBox.Show("Connect me");
       
        if (v.getId() == R.id.connect) {
            MessageBox.Show("Connect me");
            return;
        } else if(v.getId() == R.id.sendall) {

            //Add your logic here
        }
    }
}

Option - 2: If you want to set the listener from java code, then remove onClick attribute from xml and set it like below from code:

public class GeneralActivity extends AppCompatActivity {

    boolean clicked = false;
    public static String LICENCE = "";
    
    private View.OnClickListener buttonOnClick = new View.OnClickListener() {
        @Override
        public void onClick(View v) {
            switch (v.getId()) {
                case R.id.connect:
                    // Your connect logic here
                    break;
                case R.id.sendall:
                    // Your send all logic here
                    break;
            }
        }
    };

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        GlobalData.getInstance().gContext = this;
        setContentView(R.layout.activity_general);
        ((TextView) findViewById(R.id.licence)).setText(MySettings.Values().LicenceNo);
        Button connect = (Button) findViewById(R.id.connect);
        Button send = (Button) findViewById(R.id.sendall);
        
        
        connect.setOnClickListener(buttonOnClick);
        send.setOnClickListener(buttonOnClick);
    }
}

Solution:

public class MainActivity extends Activity implements View.OnClickListener {
@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);

    setContentView(R.layout.your_layout);

    Button one = (Button) findViewById(R.id.oneButton);
    one.setOnClickListener(this); // calling onClick() method
    Button two = (Button) findViewById(R.id.twoButton);
    two.setOnClickListener(this);

}
 //outside of your oncreate()
   
         public void onClick(View v) {
            switch (v.getId()) {

        case R.id.oneButton:
            // do your code
            break;

        case R.id.twoButton:
            // do your code
            break;

       default:
            break;
    }

            }

TIP: Enter new View. And then press Ctrl+Spacebar you will get the function auto generated.

you can use built it OnClick method to do this for you: here is an example of how to do it

just don't forget to implement View.OnClickListener in your Activity
`

public class GeneralActivity extends AppCompatActivity implements View.OnClickListener {
// with or without these lines below

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    GlobalData.getInstance().gContext = this;
    setContentView(R.layout.activity_general);
    ((TextView) findViewById(R.id.licence)).setText(MySettings.Values().LicenceNo);
    Button connect = findViewById(R.id.connect);
    connect.setOnClickListener(this);
    Button send = findViewById(R.id.sendall);
    send.setOnClickListener(this);
}


@Override
public void onClick(View view) {
    switch (view.getId()){
        case R.id.connect:
            //TODO
            break;
        case R.id.sendall:
            //DO something
            break;
    }
}

`