I am trying to create a doc to model with mongoose but model.create() does not return any promise

huangapple
go评论108阅读模式
英文:

I am trying to create a doc to model with mongoose but model.create() does not return any promise

问题

代码中的问题似乎在于model.create()方法未返回任何Promise，导致无法处理。这可能导致了始终返回500错误，而不提供具体的错误信息。要解决此问题，您可以尝试将model.create()包装在一个Promise中，如下所示：

  1. exports.create = async (req, res) => {
  2.   const password = await hash(req.body.password);
  3.   const rawUser = {
  4.     ...req.body,
  5.     password,
  6.   };
  8.   try {
  9.     const user = await User.create(rawUser);
  10.     const newUser = user.toObject();
  11.     res.send(newUser);
  12.   } catch (err) {
  13.     if (err.code === 11000) {
  14.       res.status(400).send({ message: 'A user with this email address has already registered.' });
  15.     } else {
  16.       res.status(500).send({ message: 'An unexpected error occurred' });
  17.     }
  18.   }
  19. };

通过这种方式，您可以更好地处理错误并获得更具体的错误信息。

英文:

it seems that the create method does not return any promise that then can handle
I tried different things but nothing worked
this is my routes file

<!-- begin snippet: js hide: false console: true babel: false -->

<!-- language: lang-js -->

  1. const express = require(&quot;express&quot;)
  2. const router = express.Router();
  5. const controller = require(&quot;./controller&quot;)
  7. router.post(&quot;/signup&quot;, controller.create);
  8.  
  10. module.exports = router;

<!-- end snippet -->

and this is my model file

<!-- begin snippet: js hide: false console: true babel: false -->

<!-- language: lang-js -->

  1. const mongoose = require(&#39;mongoose&#39;);
  3. const User = new mongoose.Schema(
  4.   {
  5.     firstName: {
  6.       type: String,
  7.       required: true
  8.     },
  9.     lastName: {
  10.       type: String,
  11.       required: true
  12.     },
  13.     
  14.     picture: {
  15.       type: String
  16.     },
  17.     password: {
  18.       type: String,
  19.       select: false
  20.     },
  21.     email: {
  22.       required: true,
  23.       type: String,
  24.       unique: true
  25.     }
  26.   },
  27.   {
  28.     timestamps: true
  29.   }
  30. );
  32. User.index({
  33.   firstName: &#39;text&#39;,
  34.   lastName: &#39;text&#39;,
  35. });
  37. module.exports = mongoose.model(&#39;User&#39;, User);

<!-- end snippet -->

and this is the controller file

<!-- begin snippet: js hide: false console: true babel: false -->

<!-- language: lang-js -->

  1. const User = require(&#39;./model&#39;);
  2. const { hash, compareHash } = require(&#39;../lib/util&#39;);
  3. const { createToken, findUserByToken } = require(&#39;../lib/auth&#39;);
  5. const cookieIsSecure = process.env.ENVIRONMENT === &#39;production&#39;;
  7. exports.create = async (req, res) =&gt; {
  8.   const password = await hash(req.body.password);
  9.   const rawUser = {
  10.     ...req.body,
  11.     password,
  12.   };
  13.   
  14.   User.create(rawUser)
  15.     .then(async user =&gt; {
  16.        return user.save();
  17.     })
  18.     .then(async user =&gt; {
  19.       const newUser = user.toObject();
  20.       res.send(newUser);
  21.     })
  22.     .catch(err =&gt; {
  23.       if (err.code === 11000) {
  24.         res.status(400).send({ message: &#39;A user with this email address has already registered.&#39; });
  25.         return;
  26.       }
  27.       res.status(500).send({ message: &#39;An unexpected error occurred&#39; });
  28.     });
  29. };

<!-- end snippet -->

it always return the 500 error "an unexpected error occurred"
which is not really specific. and i do not know what is the problem exactly. but I am sure it has something to do with the model.create() it does not return any promise.

答案1

得分: 2

这里你混合了方法。 create 方法不需要 save，因为它是隐式的：

https://mongoosejs.com/docs/api.html#model_Model.create

请尝试这样做，我已经对你的代码进行了一些重构，并添加了更容易阅读和使用的 try/catch：

  1. const rawUser = new User({ ...req.body, password});
  3. try {
  4.   await rawUser.save();
  5.   res.status(201).send(newUser);
  6. } catch(err) {
  7.   if (err.code === 11000) return res.status(400).send({ message: '此电子邮件地址的用户已经注册过了。' });
  8.   res.status(500).send({ message: '发生了意外错误' });  
  9. }
英文:

Here you are mixing methods. create doesn't want save in it as it's implicit:

https://mongoosejs.com/docs/api.html#model_Model.create

Please try this, I've refactored your code a bit and added much easier to read and use try/catch:

  1. const rawUser = new User({ ...req.body, password});
  3. try {
  4.   await rawUser.save();
  5.   res.status(201).send(newUser);
  6. } catch(err) {
  7.   if (err.code === 11000) return res.status(400).send({ message: &#39;A user with this email address has already registered.&#39; });
  8.   res.status(500).send({ message: &#39;An unexpected error occurred&#39; });  
  9. }

答案2

得分: 1

你需要像这样使用 async/await：

  1. exports.create = async (req, res) => {
  2.   try {
  3.     const password = await hash(req.body.password);
  4.     const rawUser = {
  5.       ...req.body,
  6.       password
  7.     };
  9.     const user = await User.create(rawUser);
  10.     const newUser = user.toObject();
  11.     res.send(newUser);
  12.   } catch (err) {
  13.     console.log("ERROR: ", err);
  14.     if (err.code === 11000) {
  15.       return res.status(400).send({
  16.         message: "A user with this email address has already registered."
  17.       });
  18.     }
  19.     res.status(500).send({ message: "An unexpected error occurred" });
  20.   }
  21. };
英文:

You need to use async/await like this:

  1. exports.create = async (req, res) =&gt; {
  2.   try {
  3.     const password = await hash(req.body.password);
  4.     const rawUser = {
  5.       ...req.body,
  6.       password
  7.     };
  9.     const user = await User.create(rawUser);
  10.     const newUser = user.toObject();
  11.     res.send(newUser);
  12.   } catch (err) {
  13.     console.log(&quot;ERROR: &quot;, err);
  14.     if (err.code === 11000) {
  15.       return res.status(400).send({
  16.         message: &quot;A user with this email address has already registered.&quot;
  17.       });
  18.     }
  19.     res.status(500).send({ message: &quot;An unexpected error occurred&quot; });
  20.   }
  21. };

huangapple
  • 本文由 发表于 2020年1月3日 22:26:36
  • 转载请务必保留本文链接：https://go.coder-hub.com/59580266.html
  • javascript
  • mongodb
  • mongoose
  • node.js
匿名

发表评论

匿名网友

:?: :razz: :sad: :evil: :!: :smile: :oops: :grin: :eek: :shock: :???: :cool: :lol: :mad: :twisted: :roll: :wink: :idea: :arrow: :neutral: :cry: :mrgreen:

确定