无法使用golang删除未压缩的文件夹。

huangapple
go评论113阅读模式
英文:

Unable to delete an unzipped folder using golang

问题

我写了一段代码，用于解压缩文件到指定位置，然后将文件夹的内容复制到解压缩的文件夹外部，最后删除文件夹。

问题是除了删除文件夹之外，其他都正常工作。文件夹中只有一个文件。文件的位置如下：

  1. E:\go\copyDirectory\myfile\mytextfile.txt

压缩文件的位置如下：

  1. E:\go\copyDirectory\myfile.zip

压缩文件中只有一个文本文件。压缩文件中的文件如下：

  1. E:\go\copyDirectory\myfile.zip\myfile\mytextfile.txt

我得到的错误是：

  1. ERRR::: remove myfile\mytextfile.txt: The process cannot
  2. access the file because it is being used by another process.

谢谢。

英文:

I wrote code that unzips a file in a particular location then copies the contents of the folder to outside where the folder is unzipped then it removes the folder.

This is the Code I wrote:

  1. package main
  3.  import (
  4.    "os"
  5.    "flag"
  6.    "fmt"
  7.    "io"
  8.    "path/filepath"
  9.    "os/exec"
  10.    "archive/zip"
  11.    "time"
  12.  )
  14. func RemoveContents(dir string) error {
  15.     d, err := os.Open(dir)
  16.     if err != nil {
  17.         return err
  18.     }
  19.     names, err := d.Readdirnames(-1)
  20.     if err != nil {
  21.         return err
  22.     }
  23.     for _, name := range names { 
  24. 	        err = os.RemoveAll(filepath.Join(dir, name))
  25. 	        if err != nil {
  26. 	            return err
  27. 	        }
  28.     }
  29. 	d.Close()
  30.     return nil
  31. }
  34. func CopyFile(source string, dest string) (err error) {
  35.      sourcefile, err := os.Open(source)
  36.      if err != nil {
  37.          return err
  38.      }
  40.      defer sourcefile.Close()
  42.      destfile, err := os.Create(dest)
  43.      if err != nil {
  44.          return err
  45.      }
  47.      defer destfile.Close()
  49.      _, err = io.Copy(destfile, sourcefile)
  50.      if err == nil {
  51.          sourceinfo, err := os.Stat(source)
  52.          if err != nil {
  53.              err = os.Chmod(dest, sourceinfo.Mode())
  54.          }
  56.      }
  58.      return
  59.  }
  61.  func CopyDir(source string, dest string) (err error) {
  63.      // get properties of source dir
  64.      sourceinfo, err := os.Stat(source)
  65.      if err != nil {
  66.          return err
  67.      }
  69.      // create dest dir
  71.      err = os.MkdirAll(dest, sourceinfo.Mode())
  72.      if err != nil {
  73.          return err
  74.      }
  76.      directory, _ := os.Open(source)
  78.      objects, err := directory.Readdir(-1)
  80.      for _, obj := range objects {
  82.          sourcefilepointer := source + "/" + obj.Name()
  84.          destinationfilepointer := dest + "/" + obj.Name()
  87.          if obj.IsDir() {
  88.              // create sub-directories - recursively
  89.              err = CopyDir(sourcefilepointer, destinationfilepointer)
  90.              if err != nil {
  91.                  fmt.Println(err)
  92.              }
  93.          } else {
  94.              // perform copy
  95.              err = CopyFile(sourcefilepointer, destinationfilepointer)
  96.              if err != nil {
  97.                  fmt.Println(err)
  98.              }
  99.          }
  101.      }
  102.      return
  103.  }
  108.  func main() {
  109.    	flag.Parse() // get the source and destination directory
  111. 	source_dir := flag.Arg(0) // get the source directory from 1st argument
  113. 	dest_dir := flag.Arg(1) // get the destination directory from the 2nd argument
  115.         os.MkdirAll("E:\\go\\copyDirectory\\myFile.zip",0777)
  116. 	zipFilePath := "E:\\go\\copyDirectory\\myFile.zip"
  117. 	tempWrkDir := "E:\\go\\copyDirectory\\"
  119. 	//Read zip file and get path handle.
  120. 	fileHandleReader, err := zip.OpenReader(zipFilePath)
  121. 	if err != nil {
  122. 		fmt.Println(err)
  123. 		os.Exit(1)
  124. 	}
  125. 	//open zip file and read all the folder and files inside
  126. 	for _, fileReadHandler := range fileHandleReader.Reader.File {
  127. 		//read the file or folder handle inside zip
  128. 		fileOpenHandle, err := fileReadHandler.Open()
  129. 		if err != nil {
  130. 			fmt.Println(err)
  131. 			os.Exit(1)
  132. 		}
  133. 		defer fileOpenHandle.Close()
  134. 	targetUnZipPath := filepath.Join(tempWrkDir, fileReadHandler.Name)
  135. 	if fileReadHandler.FileInfo().IsDir() {
  136. 			os.MkdirAll(targetUnZipPath, fileReadHandler.Mode())
  137. 			//fmt.Println("Creating directory", path)
  138. 		}else {
  139. 			// create new dummy file to copy original file.
  140. 			newTempFileHandle, err := os.OpenFile(targetUnZipPath, os.O_WRONLY|os.O_CREATE, fileReadHandler.Mode())
  142. 			if err != nil {
  143. 				fmt.Println(err)
  144. 				os.Exit(1)
  145. 			}
  147. 			defer newTempFileHandle.Close()
  148. 			//copying original file to dummy file.
  149. 			if _, err = io.Copy(newTempFileHandle, fileOpenHandle); err != nil {
  150. 				fmt.Println(err)
  151. 				os.Exit(1)
  152. 			}
  153. 		}
  154. 	}
  155.       time.Sleep(1000*time.Millisecond)
  157.       fmt.Println("Source :" + source_dir)
  159.       // check if the source dir exist
  160.       src, err := os.Stat(source_dir)
  161.      if err != nil {
  162.        panic(err)
  163.     }
  165.      if !src.IsDir() {
  166.        fmt.Println("Source is not a directory")
  167.        os.Exit(1)
  168.     }
  170.    // create the destination directory
  171.    fmt.Println("Destination :"+ dest_dir)
  173.    /*_, err = os.Open(dest_dir)
  174.    if !os.IsNotExist(err) {
  175.      fmt.Println("Destination directory already exists. Abort!")
  176.      os.Exit(1)
  177.    }*/
  179.    err = CopyDir(source_dir, dest_dir)
  180.    if err != nil {
  181.       fmt.Println(err)
  182.    } else {
  183.       fmt.Println("Directory copied")
  184.    }
  185. 	err = RemoveContents("./myFiles")
  186. 	   if err != nil {
  187. 	    fmt.Println("ERRR:::",err)
  188. 	   }
  189. 	//time.Sleep(10000*time.Millisecond)
  190.  }

The problem is that everything works fine except for deleting the folder. The folder has only one file in it. The location of the file is as follows:

  1. E:\go\copyDirectory\myfile\mytextfile.txt

The Location of the zip file is as follows:

  1.  E:\go\copyDirectory\myfile.zip

The zip file has only one text file. The File inside the zip file is as follows:

  1. E:\go\copyDirectory\myfile.zip\myfile\mytextfile.txt

The error I get is:

  1. ERRR::: remove myfile\mytextfile.txt: The process cannot
  2. access the file because it is being used by another process.

Thanks in advance.

答案1

得分: 2

你没有关闭文件。这段代码：

  1. defer newTempFileHandle.Close()

在主函数结束后执行，也就是在以下代码之后：

  1. err = RemoveContents("./myFiles")

你可以将这段代码放在一个无名函数中：

  1. 	func() {
  2. 		// 在 zip 文件中读取文件或文件夹句柄
  3. 		fileOpenHandle, err := fileReadHandler.Open()
  4. 		if err != nil {
  5. 			fmt.Println(err)
  6. 			os.Exit(1)
  7. 		}
  8. 		defer fileOpenHandle.Close()
  9. 		targetUnZipPath := filepath.Join(tempWrkDir, fileReadHandler.Name)
  10. 		if fileReadHandler.FileInfo().IsDir() {
  11. 			os.MkdirAll(targetUnZipPath, fileReadHandler.Mode())
  12. 			//fmt.Println("Creating directory", path)
  13. 		} else {
  14. 			// 创建一个新的虚拟文件来复制原始文件
  15. 			newTempFileHandle, err := os.OpenFile(targetUnZipPath, os.O_WRONLY|os.O_CREATE, fileReadHandler.Mode())
  17. 			if err != nil {
  18. 				fmt.Println(err)
  19. 				os.Exit(1)
  20. 			}
  22. 			defer newTempFileHandle.Close()
  23. 			// 将原始文件复制到虚拟文件中
  24. 			if _, err = io.Copy(newTempFileHandle, fileOpenHandle); err != nil {
  25. 				fmt.Println(err)
  26. 				os.Exit(1)
  27. 			}
  28. 		}
  29. 	}()

这样，你的 defer 语句将在尝试删除文件之前执行。不过我建议将这部分代码提取到一个有名字的函数中。

英文:

You aren't closing the file. This:

  1. defer newTempFileHandle.Close()

Is run when main finishes, which is after:

  1. err = RemoveContents("./myFiles")

You can wrap that bit of code in an unnamed function:

  1. 	func() {
  2. 		//read the file or folder handle inside zip
  3. 		fileOpenHandle, err := fileReadHandler.Open()
  4. 		if err != nil {
  5. 			fmt.Println(err)
  6. 			os.Exit(1)
  7. 		}
  8. 		defer fileOpenHandle.Close()
  9. 		targetUnZipPath := filepath.Join(tempWrkDir, fileReadHandler.Name)
  10. 		if fileReadHandler.FileInfo().IsDir() {
  11. 			os.MkdirAll(targetUnZipPath, fileReadHandler.Mode())
  12. 			//fmt.Println("Creating directory", path)
  13. 		} else {
  14. 			// create new dummy file to copy original file.
  15. 			newTempFileHandle, err := os.OpenFile(targetUnZipPath, os.O_WRONLY|os.O_CREATE, fileReadHandler.Mode())
  17. 			if err != nil {
  18. 				fmt.Println(err)
  19. 				os.Exit(1)
  20. 			}
  22. 			defer newTempFileHandle.Close()
  23. 			//copying original file to dummy file.
  24. 			if _, err = io.Copy(newTempFileHandle, fileOpenHandle); err != nil {
  25. 				fmt.Println(err)
  26. 				os.Exit(1)
  27. 			}
  28. 		}
  29. 	}()

And then your defer will happen before you try and remove the files. I would recommend pulling this out into a named function though.

huangapple
  • 本文由 发表于 2016年1月14日 18:51:47
  • 转载请务必保留本文链接：https://go.coder-hub.com/34787709.html
  • copy
  • directory
  • go
  • unzip
匿名

发表评论

匿名网友

:?: :razz: :sad: :evil: :!: :smile: :oops: :grin: :eek: :shock: :???: :cool: :lol: :mad: :twisted: :roll: :wink: :idea: :arrow: :neutral: :cry: :mrgreen:

确定